How to filter an array using forEach() inside filter() - Javascript

Question

I have an array of objects and I'd like to filter it based on another array. If filters object value is only one, I can use only filter, but if there are one more values in filters object, nothing show. So use forEach inside the filter and wanted to return fit values. Could you please help me what the issue is? Thanks

Expected result:

[
    {
        "tags": [
            "madewithout__gluten",
            "madewithout__nuts",
        ],
        "metafields": "Side"
    }
]

const data = [
    {
        "tags": [
            "madewithout__gluten",
            "madewithout__nuts",
        ],
        "metafields": "Side"
    },
    {
        "tags": [
            "madewithout__gluten",
        ],
        "metafields": "Side"
    },
    {
        "tags": [
            "madewithout__nuts"
        ],
        "metafields": "Side"
    }
]

const filters = ['gluten', 'nuts'] 

const result = data.filter((v) => {
  filters.forEach((tag) => {
    if(!v.tags.includes(`madewithout__${tag}`))
      return;
  });
});

console.log(result);

some-user · Accepted Answer · 2022-09-15 13:08:22Z

3

Based on the semantics of the data you provided, you want to check if all filters are contained in tags:

const result = data.filter((v) => 
    filters.every((tag) => v.tags.includes(`madewithout__${tag}`))
)

const data = [
    {
        "tags": [
            "madewithout__gluten",
            "madewithout__nuts",
        ],
        "metafields": "Side"
    },
    {
        "tags": [
            "madewithout__gluten",
        ],
        "metafields": "Side"
    },
    {
        "tags": [
            "madewithout__nuts"
        ],
        "metafields": "Side"
    }
]

const filters = ['gluten', 'nuts'] 

const result = data.filter((v) => 
    filters.every((tag) => v.tags.includes(`madewithout__${tag}`))
)

console.log(result);

answered Sep 15, 2022 at 13:08

some-user

5,0306 gold badges26 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rajesh Dixit · Accepted Answer · 2022-09-15 13:12:47Z

2

Instead of .forEach, use .some

const result = data.filter((v) => {
  return !filters.some((tag) => !v.tags.includes(`madewithout__${tag}`))
});

const data = [{
    "tags": [
      "madewithout__gluten",
      "madewithout__nuts",
    ],
    "metafields": "Side"
  },
  {
    "tags": [
      "madewithout__gluten",
    ],
    "metafields": "Side"
  },
  {
    "tags": [
      "madewithout__nuts"
    ],
    "metafields": "Side"
  }
]

const filters = ['gluten', 'nuts']

const result = data.filter((v) => {
  return !filters.some((tag) => !v.tags.includes(`madewithout__${tag}`))
});
console.log(result);

Issues with your code

Array.forEach does not return anything. So your return does not break loop or return value.
Your Array.filter does not have return statement. Due to this, by default everything is falsy (return undefined) and hence empty array

edited Sep 15, 2022 at 13:12

answered Sep 15, 2022 at 13:04

Rajesh Dixit

25k5 gold badges52 silver badges86 bronze badges

2 Comments

Roman Over a year ago

Thanks for your post, but your result is not same as my expected result. I wanted AND result

Rajesh Dixit Over a year ago

Yup realised the mistake in condition late. Ideal implementation is in @some-user's answer but do not want to make his answer void, so adding alternate in mine

Collectives™ on Stack Overflow

How to filter an array using forEach() inside filter() - Javascript

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related