Replace character in a string, using an array in a loop

Question

I have a STRING and I want to replace some character, and this characters are in an array. Here is my code :

let arrayParam = [];
arrayParam.push('X');
arrayParam.push('Y');
arrayParam.push('Z');

let stringToFilter = 'Y0000000';

let stringFiltered;

for (let i = 0; i < arrayParam.length; i++) {
  stringFiltered = stringToFilter.replace(arrayParam[i], '');
  console.log(`array:${arrayParam[i]}     stringFiltered:${stringFiltered}`);
};

This result in the console :

element:A     stringFiltered : Y0000000
element:B     stringFiltered : 0000000
element:C     stringFiltered : Y0000000

I don't understand, my var is declared outside the loop why it doesn't remember the change ?

you are not updating the value of the variable stringToFilter, it is always 'Y0000000', update it to the same value of stringFiltered — Calvin Nunes
– Calvin Nunes, Commented Sep 1, 2020 at 19:17
The replace() method returns a new string with some or all matches of a pattern replaced by a replacement. so "Y00..".replace("X"," ") return Y00... — Nur
– Nur, Commented Sep 1, 2020 at 19:23

José Luiz da Silva Neto · Accepted Answer · 2020-09-01 19:16:25Z

2

You also need to update the stringToFilter.

for(let i=0 ; i < arrayParam.length; i++ ) {
  stringFiltered = stringToFilter.replace(arrayParam[i], '');
  console.log(`array:${arrayParam[i]}  stringFiltered:${stringFiltered}`);
  stringToFilter = stringFiltered;
}

answered Sep 1, 2020 at 19:16

José Luiz da Silva Neto

1431 gold badge1 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

domenikk · Accepted Answer · 2020-09-01 19:25:06Z

1

The result is what you'd expect, in the last iteration stringFiltered is being updated to:

"Y0000000".replace("Z", '');

which results in "Y0000000".

A nicer way to achieve what you're trying would be:

const regex = new RegExp(arrayParam.join('|'), 'g');
stringFiltered = stringToFilter.replace(regex, '');

edited Sep 1, 2020 at 19:25

answered Sep 1, 2020 at 19:18

domenikk

1,7431 gold badge10 silver badges12 bronze badges

Collectives™ on Stack Overflow

Replace character in a string, using an array in a loop

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related