Skip to content
This repository was archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Add cockroach support and tests #896

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add cockroach support and tests #896

wants to merge 19 commits into from

Conversation

@lunny
Copy link
Member

@lunny lunny commented Apr 16, 2018

No description provided.

@lunny lunny added this to the 0.7 milestone Apr 16, 2018
@lunny
Copy link
Member Author

lunny commented Apr 16, 2018

Should fix #802

@codecov-io
Copy link

codecov-io commented Apr 16, 2018 •
edited
Loading

Codecov Report

Merging #896 into master will decrease coverage by 2.96%.
The diff coverage is 44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
- Coverage   57.55%   54.58%   -2.97%     
==========================================
  Files          44       42       -2     
  Lines        7966     7661     -305     
==========================================
- Hits         4585     4182     -403     
- Misses       2818     2943     +125     
+ Partials      563      536      -27
Impacted Files Coverage Δ
engine.go 61.35% <42.85%> (-1.24%) ⬇️
dialect_postgres.go 73.5% <44.44%> (-2.46%) ⬇️
dialect_mssql.go 0% <0%> (-73.81%) ⬇️
session_exist.go 57.44% <0%> (-5.52%) ⬇️
rows.go 50.76% <0%> (-5.38%) ⬇️
session_update.go 52.22% <0%> (-4.39%) ⬇️
helpers.go 57.41% <0%> (-2.32%) ⬇️
tag.go 77.09% <0%> (-2.22%) ⬇️
xorm.go 64.61% <0%> (-2.06%) ⬇️
engine_cond.go 54.96% <0%> (-1.33%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a7e44...4966715. Read the comment docs.

@lunny lunny mentioned this pull request Apr 17, 2018
Closed
2 tasks
@techknowlogick
Copy link
Contributor

techknowlogick commented Apr 17, 2018

@lunny you can use the --background flag to run cockroachdb to run in the background

@techknowlogick
Copy link
Contributor

techknowlogick commented Apr 27, 2018

@lunny it looks like a lot of failures from the tests come from the colType being STRING(255), per postgresql docs that is not an available column type.

The following table has the available column types for text/strings:

Name Description
character varying(n), varchar(n) variable-length with limit
character(n), char(n) fixed-length, blank padded
text variable unlimited length

Here is the link to the specific docs page that I am refering to: https://www.postgresql.org/docs/9.6/static/datatype-character.html

@lunny lunny modified the milestones: 0.7, 0.8 May 4, 2018
@techknowlogick techknowlogick mentioned this pull request Jun 6, 2018
Closed
@lunny lunny modified the milestones: 0.8, 0.9 Oct 10, 2018
@lunny lunny force-pushed the lunny/test_cockroach branch from ccb1e5a to 8b0cd3d Compare October 20, 2018 01:48
@vtolstov
Copy link

vtolstov commented Nov 27, 2018

gentle ping..

@lunny
Copy link
Member Author

lunny commented Nov 28, 2018

@vtolstov I will change this and test with the latest cockroach

@vtolstov
Copy link

vtolstov commented Dec 23, 2018

@lunny do you already have tests and all works fine?

@lunny lunny force-pushed the lunny/test_cockroach branch from 01f105f to 45bd5dd Compare December 23, 2018 12:42
@lunny
Copy link
Member Author

lunny commented Jan 22, 2019

Will continue the work on this PR.

@lunny lunny force-pushed the lunny/test_cockroach branch from 45bd5dd to bf552f3 Compare January 23, 2019 06:19
@lunny lunny mentioned this pull request Jan 23, 2019
Closed
@lunny lunny added the blocked label Jan 23, 2019
@lunny lunny force-pushed the lunny/test_cockroach branch 2 times, most recently from 4017eae to ceae32f Compare February 1, 2019 03:36
@lunny lunny removed the blocked label Feb 1, 2019
@lunny lunny modified the milestones: 0.9, 0.8 Feb 1, 2019
@lunny lunny force-pushed the lunny/test_cockroach branch from cbfaaba to 09b17ef Compare April 17, 2019 12:59
@lunny lunny mentioned this pull request Sep 14, 2019
Open
@lunny lunny force-pushed the lunny/test_cockroach branch from 016f204 to 4966715 Compare September 14, 2019 02:54
@vtolstov
Copy link

vtolstov commented Nov 13, 2019

please unblock comments on gitea.com/xorm/xorm repo

mei-rune pushed a commit to mei-rune/xorm that referenced this pull request Apr 19, 2020
@lunny
Add cockroach support and tests (go-xorm#896)
b079bc0 
Fix tests

fix some tests and ignore some

Add &experimental_serial_normalization=sql_sequence on test so that id will increase from 1

fix drone

Fix drone

Fix drone

Fix drone

Remove space

Add makefile

fix drone

fix drone

fix drone

update

fix tests

use sql_sequence when testing

fix postgres ci

fix circle ci for cockroach

upgrade cockroach version

add trace on error

add drone ci

run cockroach background

run cockroach backround

run cockroach backround

fix test

fix run cockroach

add cockroach test to circleci

add cockroach support

Add tests for table name (go-xorm#1...
Reviewed-on: https://gitea.com/xorm/xorm/pulls/896
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement testing

Projects

None yet

Milestone

0.8

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @codecov-io @techknowlogick @vtolstov