Gitea fails to Install using CockroachDB (PostgreSQL replacement)

[techknowlogick]

• Gitea version (or commit ref): ed4935e
• Git version: n/a
• Operating system: MacOS 10.13.4
• Database (use [x]):
  • PostgreSQL (CockroachDB 2.0)
• Can you reproduce the bug at https://try.gitea.io:
  • Not relevant
• Log gist: https://gist.github.com/techknowlogick/11a017d4342efbe1498622d76af69456

Description

First, I know CockroachDB is not supported as a DB by this project, however as it is mostly equivalent with postgresql I tried installing Gitea using it as the DB. It did not work. It got through the creating of the tables, and even inserted values into the versions table for the migrations, but once actually starting to serve web interface after installation it fatal errors. Above you can see all of the output from the stdout/stderr from the cli, but the most important line from log/gitea.log is:

2018/04/05 21:58:00 [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: sync database struct error: pq: column name "numeric_precision_radix" not found

When trying to go through install page again (after DB has been created from previous attempt, I get the error in the screenshot below).

Again CockroachDB is not supported (at least currently), and so please close this ticket if it is an invalid request, or perhaps keep it open as a proposal for future support.

Screenshots

[zllovesuki]

They do list quite a few things that are not compatible (yet).

[mqudsi]

What version of cockroach db is this? Version 2.0 should have this field:

from src/github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:

CREATE TABLE information_schema.columns (
	TABLE_CATALOG            STRING NOT NULL,
	TABLE_SCHEMA             STRING NOT NULL,
	TABLE_NAME               STRING NOT NULL,
	COLUMN_NAME              STRING NOT NULL,
	ORDINAL_POSITION         INT NOT NULL,
	COLUMN_DEFAULT           STRING,
	IS_NULLABLE              STRING NOT NULL,
	DATA_TYPE                STRING NOT NULL,
	CHARACTER_MAXIMUM_LENGTH INT,
	CHARACTER_OCTET_LENGTH   INT,
	NUMERIC_PRECISION        INT,
	NUMERIC_SCALE            INT,
	DATETIME_PRECISION       INT,
	CHARACTER_SET_CATALOG    STRING,
	CHARACTER_SET_SCHEMA     STRING,
	CHARACTER_SET_NAME       STRING,
	GENERATION_EXPRESSION    STRING
);

[techknowlogick]

@mqudsi Ah yes, I've edited my comment above to note I was using version 2.0. It is likely as @zllovesuki has suggested that perhaps something related to this query isn't supported by cockroachdb yet.

The specific query that is failing is:

SELECT column_name, column_default, is_nullable, data_type, character_maximum_length, numeric_precision, numeric_precision_radix ,
    CASE WHEN p.contype = 'p' THEN true ELSE false END AS primarykey,
    CASE WHEN p.contype = 'u' THEN true ELSE false END AS uniquekey
FROM pg_attribute f
    JOIN pg_class c ON c.oid = f.attrelid JOIN pg_type t ON t.oid = f.atttypid
    LEFT JOIN pg_attrdef d ON d.adrelid = c.oid AND d.adnum = f.attnum
    LEFT JOIN pg_namespace n ON n.oid = c.relnamespace
    LEFT JOIN pg_constraint p ON p.conrelid = c.oid AND f.attnum = ANY (p.conkey)
    LEFT JOIN pg_class AS g ON p.confrelid = g.oid
    LEFT JOIN INFORMATION_SCHEMA.COLUMNS s ON s.column_name=f.attname AND c.relname=s.table_name
WHERE c.relkind = 'r'::char AND c.relname = $1 AND s.table_schema = $2 AND f.attnum > 0 ORDER BY f.attnum;

(where $1 is user and $2 is public).

[mqudsi]

@knz any ideas?

[lunny]

I think this is blocked by go-xorm/xorm#802
resolved by xorm side in https://gitea.com/xorm/xorm

[knz]

Please file on the cockroach github, link to this issue and cc me there. Thanks -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[techknowlogick]

Just submitted a ticket on the cockroach github: cockroachdb/cockroach#24846

[knz]

As per cockroachdb/cockroach#24846 (comment):

Unfortunately the column numeric_precision_radix is implemented for information_schema.sequences but not information_schema.columns which your query is using. This is why the query fails.

In CockroachDB the only type that uses the radix 10 is decimal (also called numeric) and every other type uses radix 2. Is there any way you can use a CASE expression to determine this in your query instead of using numeric_precision_radix?

[knz]

(we'll probably add the missing column to a later version of CockroachDB. My comment above is a suggestion for a workaround until then.)

[knz]

Actually maybe other types other than decimal also use radix 10. We can check together.

[lunny]

I created a pull request go-xorm/xorm#896 to add cockroach support for xorm. The numeric_precision_radix problem has been ignored but it encountered other problem. The tests could be PASS on postgres

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.