Skip to content

[DOC-9457] Prevent special characters in filenames processed by changed_files.yml #18191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DOC-9457] Prevent special characters in filenames processed by changed_files.yml #18191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6bf0a1
Prevent special characters in filenames processed by changed_files.yml
mikeCRL Jan 4, 2024
57632fe
Tiny legitimate markdown edit to test changed_files action on this PR
mikeCRL Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/changed_files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@ jobs:
pr_num=${{ github.event.pull_request.number }}

files=`gh pr view ${pr_num} --json files -q '.files[].path'`


escaped_files=()
for file in "${files[@]}"; do
safe_file=$(printf '%q' "$file")
escaped_files+=("$safe_file")
done
printf "%s\n" "${escaped_files[@]}" > $GITHUB_ENV
Copy link
Contributor

@shannonbradshaw shannonbradshaw Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does $GITHUB_ENV carry any state or are you creating it here?


SAVEIFS=$IFS
IFS=$'\n'
files=($files)
Expand Down Expand Up @@ -74,7 +81,8 @@ jobs:
output+="</ul>"
}

for file in ${files[@]}; do
env_files=($(cat $GITHUB_ENV))
for file in "${env_files[@]}"; do
Copy link
Contributor

@shannonbradshaw shannonbradshaw Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is env_files actually going to be a list?

# only create links for Markdown files that are not includes
if [[ $file == src/**/*.md ]] && [[ $file != src/*/_* ]]
then
Expand Down
2 changes: 1 addition & 1 deletion src/current/v1.1/sql.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ summary: CockroachDB's external API is Standard SQL with extensions.
toc: false
---

At the lowest level, CockroachDB is a distributed, strongly-consistent, transactional key-value store, but the external API is [Standard SQL with extensions](sql-feature-support.html). This provides developers familiar relational concepts such as schemas, tables, columns, and indexes and the ability to structure, manipulate, and query data using well-established and time-proven tools and processes. Also, since CockroachDB supports the PostgreSQL wire protocol, it’s simple to get your application talking to Cockroach; just find your [PostgreSQL language-specific driver](install-client-drivers.html) and start building.
At the lowest level, CockroachDB is a distributed, strongly-consistent, transactional key-value store, but the external API is [Standard SQL with extensions](sql-feature-support.html). This provides developers familiar relational concepts such as schemas, tables, columns, and indexes, and the ability to structure, manipulate, and query data using well-established and time-proven tools and processes. Also, since CockroachDB supports the PostgreSQL wire protocol, it’s simple to get your application talking to Cockroach; just find your [PostgreSQL language-specific driver](install-client-drivers.html) and start building.

## See Also

Expand Down