[DOC-9457] Prevent special characters in filenames processed by changed_files.yml #18191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
shannonbradshaw
left a comment
There was a problem hiding this comment.
Left a couple of questions. How are you testing this, btw?
| safe_file=$(printf '%q' "$file") | ||
| escaped_files+=("$safe_file") | ||
| done | ||
| printf "%s\n" "${escaped_files[@]}" > $GITHUB_ENV |
Contributor
There was a problem hiding this comment.
Does $GITHUB_ENV carry any state or are you creating it here?
| for file in ${files[@]}; do | ||
| env_files=($(cat $GITHUB_ENV)) | ||
| for file in "${env_files[@]}"; do |
Contributor
There was a problem hiding this comment.
Is env_files actually going to be a list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #18181 to resolve the same matter but for our custom copy of that GH action.