Parameters and PowerShell functions

Question

I'm definitely not getting something here:

I'm creating a simple function to replicate a string x times. I am having some weird problem with the parameter -- it doesn't seem to be recognizing the second parameter. When I run the function, it returns an empty string. Further, I think it's lumping the 2 parameters into 1. Here's my code:


Function Repeat-String([string]$str, [int]$repeat) {
  $builder = new-object System.Text.StringBuilder
  for ($i = 0; $i -lt $repeat; $i++) {[void]$builder.Append($str)}
  $builder.ToString()
}

First I dot-source it to load it:

. .\RepeatString.ps1

And then I execute it like this:

Repeat-string("x", 7)
I expected a string of 7 x's. I got an empty string.

I went poking around some more, and I changed the "for" loop. I replaced the "-lt $repeat" part with "-lt 5", so that I would get a fixed number of repeats. When I did that, I got the following output (without the quotes):

Repeat-String("x", 7)

"x 7x 7x 7x 7x 7"

It looks as though it is concatenating the $str and $repeat parameters instead of treating them like 2 separate parameters. What am I doing wrong?

Peter Mortensen · Accepted Answer · 2018-09-06 19:02:09Z

17

The problem is that you need to convert your code to the following

Repeat-string "x" 7

In PowerShell, any time you put a group of values inside ()'s, you are creating an array. This means in your sample you're actually passing an array to the function as a single parameter.

edited Sep 6, 2018 at 19:02

Peter Mortensen

31.4k22 gold badges110 silver badges134 bronze badges

answered Jun 5, 2009 at 19:32

JaredPar

759k152 gold badges1.3k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

JMarsch Over a year ago

Thanks! I knew I was doing something stupid -- just wasn't sure what.

JaredPar Over a year ago

@JMarsch, everyone gets tripped up by this at least once. It's really annoying :(

Shay Levy · Accepted Answer · 2009-06-07 13:07:43Z

7

Here's a better way, just multiply your (any) string by N repeats:

PS > function Repeat-String([string]$str, [int]$repeat) {  $str * $repeat }
PS > Repeat-String x 7
xxxxxxx

PS > Repeat-String JMarsch 3
JMarschJMarschJMarsch

answered Jun 7, 2009 at 13:07

Shay Levy

128k34 gold badges193 silver badges210 bronze badges

2 Comments

JMarsch Over a year ago

Every new thing I learn about powershell just shows me how cool it is. Thanks for sharing that, Shay +1

Marcelo Finki Over a year ago

In a way, Shay Levy's comment shows that we could just use the "multiply string" feature instead of writing a user-defined-function.

Michael Sorens · Accepted Answer · 2018-10-10 14:28:52Z

A noted Chinese proverb states:

"Give a man a fish and you feed him for a day. Teach a man to fish and you feed him for a lifetime."

For the cosmopolitan-minded among you, the original is 授人以魚不如授人以漁 and the Pinyin romanization is Shòu rén yǐ yú bùrú shòu rén yǐ yú. (I have been learning to speak a smattering of Mandarin and to write Pinyin so I have to practice! Curiously I found the above Pinyin expression seemed to be an enigma, but that is a story for another time...:-)

Now to my point: JMarsch came upon a common PowerShell pitfall liable to trip up anyone used to "conventional" languages, and @JaredPar provided the correct resolution. I submit, though, that answer is akin to slapping down a fish in front of you!

Just published on Simple-Talk.com, Down the Rabbit Hole: A Study in PowerShell Pipelines, Functions, and Parameters discusses the above pitfall along with many other nuances of the function-calling interface. One section of my article, for example, covers the subtle differences between all of the following calls to function f, most of which will not yield what you expect.

f(1,2,3)
f (1,2,3)
f 1,2,3
f (1 2 3)
f 1 2 3

Look for the PDF download of the handy wallchart reference accompanying the article, too.

Here's a thumbnail: PowerShell Functions Quick Reference

(Oh, and you may want to also check out the list of humorous spin-offs of the above classic quote at Give a man a fish...)

John Weldon · Accepted Answer · 2009-06-05 19:36:02Z

0

Of course JaredPar is right.

I like to use the built in range function .. for this too: (notice I start at 1 instead of 0)

Function Repeat-String([string]$str, [int]$repeat) {
  $builder = new-object System.Text.StringBuilder
  1..$repeat | %{ [void]$builder.Append($str) }
  return $builder.ToString()
}

Repeat-string "x" 7

answered Jun 5, 2009 at 19:36

John Weldon

40.9k11 gold badges98 silver badges132 bronze badges

1 Comment

JMarsch Over a year ago

Thanks -- didn't know about the range function. I'm going to have to fit a book on powershell into my reading list. (I guess at this point, I might as well look/wait for a powershell 2.0 book)

Collectives™ on Stack Overflow

Parameters and PowerShell functions

4 Answers 4

2 Comments

2 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

2 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related