Getting byte array from XML string with encoding

Question

I have XML content in a string that defines its encoding in its declaration. I want to get a byte array from that string and download it to a client browser.

The following works, but I'm not that experienced with encoding and am wondering will I cause something to blow up if I do it this way?

Basically, I'm getting the encoding from the declaration, and using that encoding to convert the XML string to a byte array. Is that how it should work?

var xdoc = XDocument.Parse(xmlString);
var encoding = System.Text.Encoding.GetEncoding(xdoc.Document.Declaration.Encoding);

var encoded = encoding.GetBytes(xmlString);

Response.AppendHeader("Content-Disposition", "attachment; filename=" + xmlData.FileName);
return File(encoded, "text/plain");

Dave Kerr · Accepted Answer · 2012-02-15 16:58:51Z

1

You should put an exception handler around GetEncoding - it'll throw if it doesn't recognise the encoding name. Otherwise you're fine.

answered Feb 15, 2012 at 16:58

Dave Kerr

5,3572 gold badges33 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Getting byte array from XML string with encoding

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related