Function not defined - jQuery/Javascript

Question

Another hapless noob... Okay, so I've looked everywhere to try and find out how to make this jQuery/JavaScript function, I hope it's just a mistake in my syntax, but here's my code:

<script type="text/javascript">

$(function()
{
        function loadNext(choice) {
            $("#thequestion").load("question.php", { ans: choice, id: "<?php echo $row['id']; ?>", nextId: "<?php echo $nextQuestionId; ?>" } );

            $("#graph").load("graph.php", { id:"<?php echo $row['id']; ?>", nextId: "<?php echo $nextQuestionId; ?>" } );
            alert("loadNext activated");
        }

});
</script>

I then call the loadNext(choice) function using an onclick event like so: onclick="loadNext(YorN);".

Following this I get a 'loadNext is not defined' error.

Amongst the answers that I would accept are: "Y U NO LEARN!" and "You are silly."

Here is a similar problem.

Thanks.

Kenaniah · Accepted Answer · 2012-01-18 01:27:02Z

4

The loadNext function you just defined is local to the scope of your anonymous function. If you want to access it globally, then define it globally (outside of your onready handler).

answered Jan 18, 2012 at 1:27

Kenaniah

5,20126 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Naren · Accepted Answer · 2012-01-18 01:31:25Z

The outer "$(function().." you have on your first line limits your scope - the loadNext function is only available within this block and will be undefined outside of it.

The easy way to get around this is to just define the "loadnext" function outside the $(function()..) block but this is wrong for two reasons:

This makes the function global across your entire application, and polluting the global namespace is a no-no.
Inline javascript like "onclick" is bad in general - this blurs the line between presentation and logic and makes debugging a pain.

To get around this, use the jquery bind events to attach your event handlers; i.e.,

$("#myfancybutton", click(function(){ loadNext(choice) }); within your $(function()..) bloc

Carlos Barbosa · Accepted Answer · 2012-01-18 01:29:18Z

1

because you have a function inside a function

 (function()
{
        function loadNext(choice) {
            this is bad
        }

function loadNext(choice) {
            this is good
        }

onclick="loadNext()"

no probs

answered Jan 18, 2012 at 1:29

Carlos Barbosa

1,4322 gold badges24 silver badges43 bronze badges

Comments

vrunoa · Accepted Answer · 2012-01-18 01:30:30Z

1

why dont you just put your loadNext function outside of the $(function(){}) ?

answered Jan 18, 2012 at 1:30

vrunoa

7768 silver badges15 bronze badges

Comments

xdazz · Accepted Answer · 2012-01-18 01:37:09Z

1

Because loadNext is not in global scope. You can define it in global scope, or even better solution is to use .click() to bind your click event.

answered Jan 18, 2012 at 1:37

xdazz

161k38 gold badges255 silver badges278 bronze badges

Collectives™ on Stack Overflow

Function not defined - jQuery/Javascript

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related