Why doesn't this js array function work?

Question

I'm using the jQuery library, and attempting to push items to an array:

< onclick ="setFacet('myarray','val');">AOC

var myarray = [];

function setFacet(arr, bb) {
    for (var i=0; i< arr.length; i++)
        if (arr[i] == bb) 
            return true;

    arr.push(bb);
    return false;
}

I get this in chrome:

Object myarray has no method 'push'

Also, what exactly doesn't work? Do you get an error message or something? — Tikhon Jelvis
– Tikhon Jelvis, Commented Jan 17, 2012 at 4:26
@JosephSilber: It's an SO question; you have to mention jQuery to be trendy ;) — Tikhon Jelvis
– Tikhon Jelvis, Commented Jan 17, 2012 at 4:33

Tikhon Jelvis · Accepted Answer · 2012-01-17 04:27:45Z

4

Oh, I think I found the issue. In your onclick, you're calling the function with two strings. The first argument should be an array rather than 'myarray'.

If you just get rid of the quotes (and if myArray is in the global scope) it should work. That is, have it look like this:

onclick="setFacet(myArray, 'val')"

answered Jan 17, 2012 at 4:27

Tikhon Jelvis

68.3k19 gold badges183 silver badges217 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ryan Over a year ago

How Can I reference an array inside the onclick?

Tikhon Jelvis Over a year ago

Assuming myArray is a global variable, you should be able to just do onclick="setFacet(myArray, 'val')".

Alex · Accepted Answer · 2012-01-17 04:33:41Z

2

Change:

onclick="setFacet('myarray','val')"

To:

onclick="setFacet(myarray)"

then change the function setFacet to the following:

function setFacet(arr, bb) {
   for (var i=0; i< arr.length; i++)
       if (arr[i] == bb) return true;

   arr.push(this.innerHTML); /* "this" in the context of the "click" */
                             /* is the element clicked */

   return false;
}

edited Jan 17, 2012 at 4:33

answered Jan 17, 2012 at 4:28

Alex

35.5k5 gold badges81 silver badges94 bronze badges

Comments

Grace Huang · Accepted Answer · 2012-01-17 04:31:28Z

1

the element with the onclick listener should be

<...onclick ="setFacet(myarray,'val');">

myarray should not be quoted, otherwise it will be treated as a string.

answered Jan 17, 2012 at 4:31

Grace Huang

5,7575 gold badges35 silver badges55 bronze badges

Comments

Pastor Bones · Accepted Answer · 2012-01-17 04:34:16Z

0

You could separate your javascript from your markup altogether and just store the value as an attribute of the clicked element (or any other element)

<input type="button" value="someValue">

<script>
  $(function(){
    var myArray = [];

    $('#myEle').click(function(){
      myArray.push($(this).val())
    })
  })
</script>

answered Jan 17, 2012 at 4:34

Pastor Bones

7,3813 gold badges39 silver badges56 bronze badges

Collectives™ on Stack Overflow

Why doesn't this js array function work?

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related