Return empty string in decimal function in c#

Question

I create a function to compare the price of my item. This is my function:

public static decimal ComparePrice(decimal Price, decimal WebsitePrice)
    {
        decimal ZERO_PRICE = 0.00000M;
        if(Price == ZERO_PRICE && WebsitePrice > ZERO_PRICE){
            return WebsitePrice;
        }else if(Price == ZERO_PRICE && WebsitePrice == ZERO_PRICE){
            return "";
        }else{
            return Price;
        }

    }

if the both(price and websiteprice) is equal 0.00, then it will return the empty string, I know it is not possible to return the string while the function is set to decimal type, but i have no idea what should I do about that. Anyone can help? Thanks.

Zyo · Accepted Answer · 2011-12-14 05:08:02Z

6

If it makes sense in your application logic, you can use a Nullable type and use null instead of an empty string. Like :

public static decimal? ComparePrice(decimal Price, decimal WebsitePrice)
    {
        if(Price == decimal.Zero && WebsitePrice > decimal.Zero){
            return WebsitePrice;
        }else if(Price == decimal.Zero && WebsitePrice == decimal.Zero){
            return null;
        }else{
            return Price;
        }

    }

Or use Decimal.MinValue as suggested as a flag for invalid. (I like the null better, again, just if this is actually a valid value in your logic).

edited Dec 14, 2011 at 5:08

Zyo

2,07623 silver badges26 bronze badges

answered Dec 14, 2011 at 2:30

Francisco Soto

10.4k2 gold badges40 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Tabish Sarwar · Accepted Answer · 2011-12-14 02:28:26Z

2

Why dont you return simple 0.0 Of course when both values are 0.0 .. returning 0.0 make sense.

answered Dec 14, 2011 at 2:28

Tabish Sarwar

1,5331 gold badge11 silver badges18 bronze badges

2 Comments

Nothing Over a year ago

umm... If I return 0.0, then I have to test again in my view, if the return value = 0.0 , then display empty string. Because all the items should not display its price = 0.0.

Tabish Sarwar Over a year ago

consider using nullable types as suggested by anthony and Francisco.

anthony · Accepted Answer · 2011-12-14 02:30:28Z

2

C# has had nullable types for quite a while now, try defining your method like this and returning null for the case in question:

public static decimal? ComparePrice(decimal Price, decimal WebsitePrice)

answered Dec 14, 2011 at 2:30

anthony

41.2k7 gold badges57 silver badges129 bronze badges

1 Comment

M.Babcock Over a year ago

+1 for using standard ways of implementing this functionality.

Jared Peless · Accepted Answer · 2011-12-14 02:27:12Z

1

You could always return something like decimal.MinValue that would indicate they were both a zero price item.

answered Dec 14, 2011 at 2:27

Jared Peless

1,1209 silver badges11 bronze badges

Collectives™ on Stack Overflow

Return empty string in decimal function in c#

4 Answers 4

Comments

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related