Javascript: working with query string

Question

I'm trying to write a Javascript function to get the query string of the browser and allow a new key/value to be passed to the function. If the key exists, I need to replace the value. Since I've spent the last 3.5 hours on this, I haven't yet gotten around to the replacing part.

So far, I'm using the answer here: How to get the query string by javascript? to get the query string. However, it doesn't appear to work... The URL I was testing with was: http://www.site.com/poo?drwho=tombaker&companion=k9

  var assoc  = {}; 
  var decode = function (s) { return decodeURIComponent(s.replace(/\+/g, " ")); }; 
  var queryString = location.search.substring(1);  
  var keyValues = queryString.split('&');  

  for(var i in keyValues) {  
     var key = keyValues[i].split('=');  
     assoc[decode(key[0])] = decode(key[1]);  
  }  

  if(assoc["dr"] === undefined ) { 
     // not found. todo: replace
  }

I'd really appricate any help! Is there any simpler way of doing this using JQuery?

When I try your code and add an alert(assoc["drwho"]); at the end, it outputs "tombaker", just as expected... — codeling
– codeling, Commented Dec 3, 2011 at 1:09
Tried again using jsFiddle and it works. I was using the W3C one. — Alex Guerin
– Alex Guerin, Commented Dec 3, 2011 at 2:47

gilly3 · Accepted Answer · 2011-12-03 02:09:17Z

2

Copy and pasted your code here: http://jsfiddle.net/6KcWh/5/, and added a call to JSON.stringify() to examine the contents of assoc. It turns out assoc is not undefined. But, of course assoc.dr is undefined, because there is no querystring argument of dr. There is a querystring argument of drwho. It looks like you were looking for the wrong querystring argument.

answered Dec 3, 2011 at 2:09

gilly3

92.6k26 gold badges148 silver badges179 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 10:08:19Z

1

You appear to be misusing for...in.

Try converting your for loop to a standard for (i = 0 ; i < keyValues.length; i++) and check out some other answers about what for...in is used for in JavaScript.

edited May 23, 2017 at 10:08

CommunityBot

11 silver badge

answered Dec 3, 2011 at 0:45

Ken Browning

29.1k6 gold badges58 silver badges68 bronze badges

2 Comments

codeling Over a year ago

No misuse here; the "for...in" construct is a proper "for each" loop, javascript syntax

Alex Guerin Over a year ago

Thanks. Tried it with link and all works. I was using the W3C one.

Collectives™ on Stack Overflow

Javascript: working with query string

2 Answers 2

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related