ASP.NET MVC 3: Extension method on UrlHelper/HtmlHelper encodes to HTML

Question

I have written some extension methods for UrlHelper in order to more easily load a , or tag. However, it seems that it renders to literal text in the browser. Here is what I have:

public static string Script(this UrlHelper helper, string scriptPath)
        {
            return string.Format(@"<script src=""{0}"" type=""text/javascript""></script>", helper.Content(scriptPath));
        }

Here is my .cshtml code:

@section HeadContent
{
    @Url.Style("MyStyleName")
    @Url.Script("MyScriptName")
    @Url.MetaKeywords("My Keywords")
    @Url.MetaDescription("Some Description")
}

and it comes out in the browser with <script [etc, etc]>

If I don't use the extension methods, it will as expected, work correctly... how can I make it work with my extensions?

Abdul Munim · Accepted Answer · 2011-11-19 12:21:24Z

2

Try this:

public static string Script(this UrlHelper helper, string scriptPath)
{
    return MvcHtmlString.Create(string.Format(@"<script src=""{0}"" type=""text/javascript""></script>", helper.Content(scriptPath)));
}

answered Nov 19, 2011 at 12:21

Abdul Munim

19.2k8 gold badges54 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Matt Over a year ago

Thank you, friend! That is just what I needed. Only thing is the return type must also be MvcHtmlString. Thanks again.

Abdul Munim Over a year ago

Welcome mate! Please consider the answer as accepted for other people to know the right answer.

Matt Over a year ago

Indeed. I am waiting until I am able to accept the answer...it says I cannot do that for another 3 minutes! Crazy stuff...

Dallas · Accepted Answer · 2011-11-20 15:59:58Z

2

All HTML helpers need to return MvcHtmlString. If you just return a string, it will be treated as an untrusted value and will be HTML-encoded.

edited Nov 20, 2011 at 15:59

answered Nov 19, 2011 at 12:23

Dallas

2,2371 gold badge13 silver badges13 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC 3: Extension method on UrlHelper/HtmlHelper encodes to HTML

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related