java.lang.NullPointerException ERROR

Question

I'm getting this null error on this line but I'm doing an if check and setting an empty string if null. Am I doing this wrong?

java.lang.NullPointerException
at form.setSam((teamBean.getHead().getNone().getCode() == null) ? "" : teamBean.getHead().getNone().getSamCode().toString());   //SAM

Code:

public int show(Action action) throws Exception
{
    HttpServletRequest request = action.getRequest();

    String[] params;

    if (!isEmpty(params[0]))
    {

    String teamNumber= params[0];

    TeamBean teamBean = DAO.getTeamDAO().getTeamByNumber(Long.parseLong(teamNumber));

    Fake form = new fakeForm();

    form.setMoor(teamBean.getHeader().getMoor()); 
    form.setDoor(Double.toString(teamBean .getDoors()));    
    form.setURC(Double.toString(teamBean.getURCS()));   
    form.setUMC(Double.toString(teamBean.getUMCSt()));  
    form.setWeek(Long.toString(teamBean.getHead().getWeek().getnow())); //WEEK
   ERROR HERE -->>   form.setSam((teamBean.getHead().getNone().getCode() == null) ? "" : teamBean.getHead().getNone().getSamCode().toString()); //SAM

What's the point of (jobPlanBean.getHeader().getNsn().getStoresAccountCode() == null) ? "" : "".... You always set it to "", might as well just do setSac("") -- and yes @JB Nizet, I hadn't seen the "ERROR HERE", deleted my first comment when I saw it ;) — Guillaume
– Guillaume, Commented Oct 2, 2011 at 17:07
sorry....I wrote it that way for testing purposes....this is how its supposed to look like this: — Doc Holiday
– Doc Holiday, Commented Oct 2, 2011 at 17:12

Flexo - Save the data dump · Accepted Answer · 2013-03-19 20:57:52Z

3

For clarity, this is the expression that gives you the NullPointerException:

teamBean.getHead().getNone().getCode()

You aren't checking if getNone returns null.

edited Mar 19, 2013 at 20:57

Flexo - Save the data dump♦

89.1k22 gold badges205 silver badges286 bronze badges

answered Oct 2, 2011 at 17:04

Mark Byers

844k202 gold badges1.6k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Flexo - Save the data dump · Accepted Answer · 2013-03-19 21:00:18Z

2

You get it because teamBean.getHead().getNone() is null. And since you're calling getCode() on this null value, you get a NullPointerException.

Note that

form.setSam((teamBean.getHead().getNone().getCode() == null) ? "" : "");

could be rewritten as

form.setSac("");

(except you wouldn't have the NullPointerException)

edited Mar 19, 2013 at 21:00

Flexo - Save the data dump♦

89.1k22 gold badges205 silver badges286 bronze badges

answered Oct 2, 2011 at 17:04

JB Nizet

694k94 gold badges1.3k silver badges1.3k bronze badges

Collectives™ on Stack Overflow

java.lang.NullPointerException ERROR

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related