insert data with node-mysql in loop

Question

My code is as follows:

var mysql= require('mysql');

var client = mysql.createClient({
    user: 'root',
    password: 'root',
    host: 'localhost'
});

client.query('USE sample');

for(var k=0;k<=100;k++)
{

    var sql="SELECT `id` FROM `data` WHERE `id`= ?";

    console.log(k);

    client.query(sql,[k],function(err,results,field){

        console.log("DATABASE "+k);
        if(results.length == 0) {

            var sql2="INSERT INTO `data` (`id`) VALUES (?);";

            client.query(sql2,[k],function(err,results,field){

            });

        }
    });

}

client.end();

When I run this code , the results are as follows:

1
2
3
...
100
Database 101
Database 101
Database 101
...
Database 101

and it neither closes the database connection nor inserts any data.

I want to insert data in the loop. But before inserting the new record , it also needs to check whether it already exists or not.

sethobrien · Accepted Answer · 2011-08-21 06:24:39Z

6

The closure for the callback function binds to the variable k by reference, not by value. This means that by the time you execute the callbacks, they all get the latest k value (101). In order to bind to the current k value at the time of closure creation, you need to add a new variable scope. Perhaps something like this:

for(var k=0;k<=100;k++) {
    var sql="SELECT `id` FROM `data` WHERE `id`= ?";
    console.log(k);
    (function () {
        var kCopy = k;
        client.query(sql,[kCopy],function(err,results,field){
            console.log("DATABASE "+kCopy);
            if(results.length == 0) {
                var sql2="INSERT INTO `data` (`id`) VALUES (?);";
                client.query(sql2,[kCopy],function(err,results,field){});
            }
        });
    }());
}

answered Aug 21, 2011 at 6:24

sethobrien

1,03910 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mohammad Kermani Over a year ago

kCopy seems to not be required

Collectives™ on Stack Overflow

insert data with node-mysql in loop

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related