Passing db connection between functions

Question

I'm fairly new at PHP and so maybe this is a simple question. This is a class I use to update a database. The problem is that it keeps giving me an error at the line marked * because it can't find $con, which is clearly in the function openconn(). It seems I can't pass the connection to another function. Am I doing something wrong?Thanks

class retreats {

    public $retreat_name = '';

    function openconn() {
        $con = mysql_connect("localhost","root","root");

        if (!$con)
        {
            die('Could not connect: ' . mysql_error());
        }
        mysql_select_db("PHPTest", $con);
    }


    function closeconn(){
        mysql_close($con);
    }


    function add_retreat(){
        openconn();
        $sql="INSERT INTO tbl_retreats (retreat_name) VALUES ('".$this->retreat_name."')";

        if (!mysql_query($sql,$con)) *******
        {
            die('Error: ' . mysql_error());
        }

        echo "Record Successfully Added";

        closeconn();

    }
}

your not returning the connection handler. $con from openconn() — Lawrence Cherone
– Lawrence Cherone, Commented Aug 19, 2011 at 1:17
Allen, I advise you to read up on the basics of Object Oriented Programming (OOP) and properties — Decent Dabbler
– Decent Dabbler, Commented Aug 19, 2011 at 1:23

Fabio · Accepted Answer · 2011-08-19 01:18:49Z

3

$con is a local variable for the function openconn. Try to change your code in this way:

class retreats {  

    public $retreat_name = ''; 

    private $con;

    function openconn() {
    $this->con = mysql_connect("localhost","root","root");

    if (!$this->con)
    {
        die('Could not connect: ' . mysql_error());
    }
        mysql_select_db("PHPTest", $this->con);
    }


    function closeconn(){
        mysql_close($this->con);      
    }


    function add_retreat(){  
        openconn();
        $sql="INSERT INTO tbl_retreats (retreat_name) VALUES ('".$this->retreat_name."')"; 

        if (!mysql_query($sql,$this->con))
        {
            die('Error: ' . mysql_error());
        }
            echo "Record Successfully Added";

        closeconn();  

    }     

   }

answered Aug 19, 2011 at 1:18

Fabio

19.3k9 gold badges85 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Lawrence Cherone · Accepted Answer · 2011-08-19 03:51:33Z

A Simple PDO port of your code...

<?php
class pdoDB{
    //PDO Connect
    function connect($host,$db,$user,$pass){
        $this->dbh = new PDO('mysql:host='.$host.';dbname='.$db, $user, $pass);
    }

    function query($query){
        $this->retreat_name = $query;
        $this->prepare();
    }

    function prepare(){
        /* Execute a prepared statement by binding PHP variables */
        $this->sth = $this->dbh->prepare('INSERT INTO tbl_retreats (retreat_name) VALUES (:value)');
        $this->sth->bindParam(':value', $this->retreat_name);
        $this->execute();
    }

    function execute(){
        $this->sth->execute();
    }

    function result(){
        if ($this->sth->rowCount() > 0) {
            return 'Record Successfully Added';
        }else{
            return 'Record Not Inserted';
        }
    }

    function close(){
        $this->sth = null;
    }
}


$db = new pdoDB();
$db->connect('localhost','PHPTest','root','pass');

$db->query('Barcelona'); //or $db->query($_POST['retreat_name']);

echo $db->result();

$db->close();
?>

BenMorel · Accepted Answer · 2013-12-06 14:56:51Z

1

You need to first declare the $con in the class. Just put it after the public $retreat_name = '';

put

public $retreat_name = ''; 
private $con;

after that, you can use it in other functions using the $this keyword.

mysql_close($this->con);

edited Dec 6, 2013 at 14:56

BenMorel

37k52 gold badges208 silver badges339 bronze badges

answered Aug 19, 2011 at 1:20

Sufendy

1,2302 gold badges16 silver badges30 bronze badges

Comments

René Höhle · Accepted Answer · 2012-11-13 14:02:27Z

0

it turns out you need to do this

$this->openconn();

instead of just

openconn();

edited Nov 13, 2012 at 14:02

René Höhle

27.4k22 gold badges78 silver badges91 bronze badges

answered Aug 20, 2011 at 4:09

Allen

7124 gold badges13 silver badges33 bronze badges

Collectives™ on Stack Overflow

Passing db connection between functions

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related