Recursion forEach does not update my values? using Javascript

Question

I need to update my values with recursion but my loop no work? First check code:

  const minusItem = (items) => {
    console.log("items", items);
    if (items.length > 0) {
      items.forEach((orgUnit) => {
        orgUnit.dashCheck = true;
        orgUnit.allChildItemChecked = false;
        if (orgUnit.parentNode.unitId) {
          minusItem(orgUnit.parentNode); //recursion
        }
      });
    }
  };

items is array but worst of all sometimes an object is sent but there is an if that says

items.length > 0

here I filter only strings that have length> 0

array is like

[
 { 
 unitId: 1 ,
 title: "Test 1 " ,
 dashCheck: false,
 allChildItemChecked: false
 parentNode: {
    unitId: 2 ,
    title: "Test 2" ,
    dashCheck: false,
    allChildItemChecked: false, 
    parentNode: { 
       unitId: 3 ,
       title: "Test 3" ,
       dashCheck: false,
       allChildItemChecked: false, 
        }
      } 
   }
]

of these parentNode can have 100....

I need to loop thought each and set

    orgUnit.dashCheck = true;
    orgUnit.allChildItemChecked = false;

trincot · Accepted Answer · 2022-02-10 07:15:19Z

2

You only have one array. The nested objects are not arrays, so they don't have a length property.

The forEach should be moved outside of the recursive function, where it will execute only once:

const minusItem = (item) => {
    item.dashCheck = true;
    item.allChildItemChecked = false;
    if (item.parentNode) { // Just check if there is a parent node
        minusItem(item.parentNode); //recursion 
    }
};

let data = [{ 
 unitId: 1 ,
 title: "Test 1 " ,
 dashCheck: false,
 allChildItemChecked: false,
 parentNode: {
    unitId: 2 ,
    title: "Test 2" ,
    dashCheck: false,
    allChildItemChecked: false, 
    parentNode: { 
       unitId: 3 ,
       title: "Test 3" ,
       dashCheck: false,
       allChildItemChecked: false, 
    }
  } 
}];

data.forEach(minusItem); // The only place to perform a loop
console.log(data);

Moving the iteration inside a function:

If you need the main function to be minusItem and to be called on the original array, then make a second function for the recursive part:

const minusItem = (items) => items.forEach(minusItemRecur);

const minusItemRecur = (item) => {
    item.dashCheck = true;
    item.allChildItemChecked = false;
    if (item.parentNode) { // Just check if there is a parent node
        minusItemRecur(item.parentNode); //recursion 
    }
};

let data = [{ 
 unitId: 1 ,
 title: "Test 1 " ,
 dashCheck: false,
 allChildItemChecked: false,
 parentNode: {
    unitId: 2 ,
    title: "Test 2" ,
    dashCheck: false,
    allChildItemChecked: false, 
    parentNode: { 
       unitId: 3 ,
       title: "Test 3" ,
       dashCheck: false,
       allChildItemChecked: false, 
    }
  } 
}];

minusItem(data);
console.log(data);

edited Feb 10, 2022 at 7:15

answered Feb 5, 2022 at 21:09

trincot

357k38 gold badges282 silver badges338 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user18113903 Over a year ago

Is possible to data.forEach (minusItem); not calling? Because it creates some other problems for me so i would just like to pass the value and within the minusItem function changes are happening

trincot Over a year ago

No, you'll have to iterate. You can of course wrap that part in yet another function. I don't see the problem. Added an alternative to my answer with a second function

A1exandr Belan · Accepted Answer · 2022-02-06 08:35:41Z

1

Lodash cloneDeepWith if you don't mind

const data = [{unitId: 1 ,title:"Test 1 ",dashCheck: false,allChildItemChecked:false,parentNode:{unitId:2,title:"Test 2" ,dashCheck:false,allChildItemChecked:false,parentNode:{unitId:3 ,title:"Test 3",dashCheck:false,allChildItemChecked:false}}}];

const result = _.cloneDeepWith(data, (val, key) => {
    if (key === 'dashCheck') return true;
    if (key === 'allChildItemChecked') return false;       
});

console.log(result);

.as-console-wrapper{min-height: 100%!important; top: 0}

<script src="https://cdn.jsdelivr.net/npm/[email protected]/lodash.min.js"></script>

answered Feb 6, 2022 at 8:35

A1exandr Belan

4,7803 gold badges30 silver badges53 bronze badges

Collectives™ on Stack Overflow

Recursion forEach does not update my values? using Javascript

2 Answers 2

Moving the iteration inside a function:

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Moving the iteration inside a function:

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related