PHP can't upload file from HTML form

Question

This is how I handle my form:

        # Create the message
        # ----------------------------------------------------------------
        $name = $_POST['name'];
        $email = $_POST['email'];
        $title = $_POST['title'];
        $course = $_POST['course'];
        $file = $_POST['file'];

        $message  = "Name: ".$name."\n";
        $message .= "Email: ".$email."\n\n";
        $message .= "Title of Article: ".$title."\n";
        $message .= "Program: ".$course."\n\n";
        $message .= "Additional Info: ".$info;

        # Upload temporary files
        # ----------------------------------------------------------------
        $uploaddir = '/home/public/uploads/';
        $uploadfile = $uploaddir . basename($_FILES['file']['name']);
        if (move_uploaded_file($_FILES['file']['tmp_name'], $uploadfile) == false) {
            echo 'Could not move file';
            exit;
        }

        if ($_FILES['file']['type'] != "application/pdf") {
            echo 'Not a pdf file';
            unlink($uploadfile);
            exit;
        }

The end product is hopefully sending an email with the file as an attachment. Right now I'm failing and getting the "Could not move file" message I built in. Is there an obvious reason why? $file is what I get from a file dialog in HTML (input type="file")

user754962 · Accepted Answer · 2011-08-08 01:31:35Z

4

Two things:
1. Is the form set to:

<form method="POST" enctype="multipart/form-data" action="INSERT ACTION">

2. Is the folder your posting the file to, is it set to 777?

answered Aug 8, 2011 at 1:31

user754962

Sign up to request clarification or add additional context in comments.

6 Comments

user623990 Over a year ago

Yeah I chmoded that folder to 777, I added the enctype and I'm just working out a couple syntax errors. I think this might be the issue.

user623990 Over a year ago

The second I added the enctype, it seems that nothing is getting stored in $_POST .... is this normal?

user754962 Over a year ago

Yes actually. You need to use $_FILE[''];

Phil Over a year ago

@Jake He should still get the other form data in $_POST. Also, it's $_FILES (plural)

user754962 Over a year ago

@Phil Hmm, actually now that I think about it, that is true. odd. And yes he is right, it's $_FILES Sorry for the mistake.

|

Phil · Accepted Answer · 2011-08-08 01:40:54Z

2

Your form needs to have the appropriate enctype attribute set, ie

<form enctype="multipart/form-data" method="post" action=... >

Update

A couple of suggestions...

Check the file type and do any other general validation before you move the uploaded file. That should be your last step.
Can't remember exactly right now but I don't think you'll get anything useful (or at all) in the $_POST['file'] value. Use the $_FILES array for all uploaded file data.

edited Aug 8, 2011 at 1:40

answered Aug 8, 2011 at 1:30

Phil

166k25 gold badges265 silver badges269 bronze badges

3 Comments

user623990 Over a year ago

Thanks for the info, I'll use regex to check the extension at least. Any ideas about the comment I posted below?

Phil Over a year ago

@Max You don't need to change your validation method, just move the "PDF check" block above the "move uploaded file" block

user623990 Over a year ago

Yeah I just finished the code. It works flawlessly, thanks :) I'm performing all checks before I upload the file.

Collectives™ on Stack Overflow

PHP can't upload file from HTML form

2 Answers 2

6 Comments

Update

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Update

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related