how to display array output in a vertical list?

Question

I'm making a simple page which displays 7 days on button click. I'd like the days to be displayed in a vertical list type of format, but the days are being displayed in a single line. When I try using the forEach function to display 'dayslist', it only shows one day name. How can it be displayed in a vertical list?? Thankyou.

HTML:

<div id="weekdivid">
  <h3>Days in a week</h3>
  <button onclick="showdays()">Show days</button>
  <p id="showdayspid"></p>
</div>

Javascript:

function showdays() {
  const days = ["Sun", "Mon", "Tue", "Wed", "Thurs", "Fri", "Sat"];
  days.forEach(function (daylist) {
    document.getElementById("showdayspid").innerHTML = days + "<br>";
  });
}

You're using the wrong variable, and you're not appending: .innerHTML += daylist + "<br>" — Barmar
– Barmar, Commented Jun 23, 2021 at 15:30
Shouldn't document.getElementById("showdayspid").innerHTML = days + "<br>"; be document.getElementById("showdayspid").innerHTML += daylist + "<br>";, instead? — secan
– secan, Commented Jun 23, 2021 at 15:30

Hassan Imam · Accepted Answer · 2021-06-23 16:14:58Z

2

You can use array#join() to add br tag.

(function showdays() {
  const days = ["Sun", "Mon", "Tue", "Wed", "Thurs", "Fri", "Sat"];
  document.getElementById("showdayspid").innerHTML = days.join('<br>');
})();

<div id='showdayspid'></div>

answered Jun 23, 2021 at 16:14

Hassan Imam

22.6k6 gold badges45 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Joe Lissner · Accepted Answer · 2021-06-23 15:29:51Z

1

You need to use += instead of = in your foreach, something like:

function showdays() {
  const days = ["Sun", "Mon", "Tue", "Wed", "Thurs", "Fri", "Sat"];
  days.forEach(function (day) {
    document.getElementById("showdayspid").innerHTML += day + "<br>";
  });
}

answered Jun 23, 2021 at 15:29

Joe Lissner

2,4831 gold badge20 silver badges25 bronze badges

Comments

paddyfields · Accepted Answer · 2021-06-23 15:41:00Z

1

You could also refactor this slightly so that you're not using getElementById unnecessarily in the forEach to find the same element each time.

function showdays() {
    const dayNode = document.getElementById("showdayspid");
    const days = ["Sun", "Mon", "Tue", "Wed", "Thurs", "Fri", "Sat"];
    let dayResult;
    days.forEach(function (day) {
      dayResult += day + "<br>";
    });
   dayNode.innerHTML = dayResult;
}

answered Jun 23, 2021 at 15:41

paddyfields

1,5492 gold badges17 silver badges28 bronze badges

Comments

secan · Accepted Answer · 2021-06-23 16:09:57Z

As you are displaying a list of related items, it would be advisable to use the proper HTML tag (either <ul></ul> or <ol></ol>):

const days = ["Sun", "Mon", "Tue", "Wed", "Thurs", "Fri", "Sat"];

function populateDaysList() {
  // select the list element
  const listElement = document.querySelector('#daysList');
  
  // if needed, you can style it to make it look like 'normal' text
  // or, even better, you style it in the CSS
  // listElement.style.listStyle = 'none';
  // listElement.style.padding = 0;
  
  days.forEach(item => {
    // create the list item...
    const li = document.createElement('li');
    // ... add the text to it...
    li.innerText = item;
    // ... and append it to the list element
    listElement.append(li);
  })
}

populateDaysList()

#daysList {
  list-style: none;
  padding: 0
}

<ul id='daysList'>

</ul>

Anyway, if for any reason you have to stick to the approach you used, you have to amend your code so that it adds new lines to the parent element innerHTML rather than entirely replacing it with a stringified version of the array followed by <br>:

const days = ["Sun", "Mon", "Tue", "Wed", "Thurs", "Fri", "Sat"];

function showdays() {
  const containerElement = document.getElementById("showdayspid");
  days.forEach(day => containerElement.innerHTML += `${day}<br>`)
}

showdays();

<div id=showdayspid>

</div>

Collectives™ on Stack Overflow

how to display array output in a vertical list?

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related