Node.js callback not working

Question

I have the following two Node.js files:

//test.js
var hash=require('./hash');
var sys=require('sys');

hash.hash("asdf",function(param){
        sys.puts(param);
});

and

//hash.js:
var exec=require('child_process').exec;
var sys=require('sys');

exports.hash=function(data,callback){
        exec("./a.out "+data,function callback(error,stdout,stderr){
                callback(stdout);
        });
}

As you can see, I'm trying to make stdout available in test.js

Trouble is, when I run node test.js, I get the following error:

eamorr@Compaq6000:~/Desktop/simple-hash$ node test.js 

node.js:134
        throw e; // process.nextTick error, or 'error' event on first tick
        ^
RangeError: Maximum call stack size exceeded

Anyone got any ideas as to what I might be doing wrong?

Many thanks in advance,

Edit: solution: rename the inner "callback" to "callback2" or something else... Thanks to Idan K for pointing this out.

Idan K · Accepted Answer · 2011-07-22 11:14:29Z

1

When you call exec you are naming what should be an anonymous function, callback. This has the same name as the second argument to hash, hence the recursion.

answered Jul 22, 2011 at 11:14

Idan K

21k11 gold badges65 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Eamorr Over a year ago

yes, I just realised this! Thank you so much for pointing that out. bangs head off desk

Idan K Over a year ago

@Eamorr: there's actually no need to give it a name, but changing the name will fix it too.

Collectives™ on Stack Overflow

Node.js callback not working

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related