Remove object in array by id javascript

Question

I have two arrays like so:

const data = [
    {
        createOn: "2021-02-06T18:03",
        data: [
            {id: "1612634593915", createOn: "2021-02-06T18:03:13.915"},
            {id: "1612634622462", createOn: "2021-02-06T18:03:42.462"},
            {id: "1612634584081", createOn: "2021-02-06T18:03:04.081"},
        ]
    },
    {
        createOn: "2021-02-06T18:02",
        data: [
            {id: "1612634576145", createOn: "2021-02-06T18:02:56.145"},
            {id: "1612634557111", createOn: "2021-02-06T18:02:37.110"}
        ]
    }
]
const listId = ['1612634622462', '1612634557111'];

Then I try to remove object in array by id in listId

const remove = data.map(re => {
    re.data.filter(item => {
        return !listId.includes(item.id);
    })
});

But when I log it out, I got [undefined, undefined].

I want array return like so after remove:

const data = [
    {
        createOn: "2021-02-06T18:03",
        data: [
            {id: "1612634593915", createOn: "2021-02-06T18:03:13.915"},
            {id: "1612634584081", createOn: "2021-02-06T18:03:04.081"},
        ]
    },
    {
        createOn: "2021-02-06T18:02",
        data: [
            {id: "1612634576145", createOn: "2021-02-06T18:02:56.145"}
        ]
    }
]

Can you help me. Thank you :))

Sometimes I don't get the need to post ton of answers if there are 1-2 good approaches already.. What good does it give to the community if the answers are pretty much the same?! — Mike B
– Mike B, Commented Mar 3, 2021 at 13:42

Nghi Nguyen · Accepted Answer · 2021-03-03 13:41:00Z

2

const data = [
    {
        createOn: "2021-02-06T18:03",
        data: [
            {id: "1612634593915", createOn: "2021-02-06T18:03:13.915"},
            {id: "1612634622462", createOn: "2021-02-06T18:03:42.462"},
            {id: "1612634584081", createOn: "2021-02-06T18:03:04.081"},
        ]
    },
    {
        createOn: "2021-02-06T18:02",
        data: [
            {id: "1612634576145", createOn: "2021-02-06T18:02:56.145"},
            {id: "1612634557111", createOn: "2021-02-06T18:02:37.110"}
            ]
        
    }
]
const listId = ['1612634622462', '1612634557111'];

const newData = data.map(item => {
  item.data = item.data.filter(item => !listId.includes(item.id))
  return item
})

console.log(newData)

answered Mar 3, 2021 at 13:41

Nghi Nguyen

9586 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mamun · Accepted Answer · 2021-03-03 13:43:29Z

You should return the result from .map():

const data = [
    {
        createOn: "2021-02-06T18:03",
        data: [
            {id: "1612634593915", createOn: "2021-02-06T18:03:13.915"},
            {id: "1612634622462", createOn: "2021-02-06T18:03:42.462"},
            {id: "1612634584081", createOn: "2021-02-06T18:03:04.081"},
        ]
    },
    {
        createOn: "2021-02-06T18:02",
        data: [
            {id: "1612634576145", createOn: "2021-02-06T18:02:56.145"},
            {id: "1612634557111", createOn: "2021-02-06T18:02:37.110"}
        ]
    }
]
const listId = ['1612634622462', '1612634557111'];

const remove = data.map(re => {
    re.data = re.data.filter(item => {
        return !listId.includes(item.id);
    });
    return re; // return here
});
console.log(remove);

Mike B · Accepted Answer · 2021-03-03 13:36:09Z

0

Your initial problem is that your inner map() function doesn't doesn't return a value - for each object in the data array. That's why is returned undefined for both iterations. Also - If you filter() the array, you have to reassign it to itself to keep only filtered elements.

data.forEach(re => {
    re.data = re.data.filter(item => {
        return !listId.includes(item.id);
    })
});

answered Mar 3, 2021 at 13:36

Mike B

2,7942 gold badges18 silver badges28 bronze badges

1 Comment

Linh Nguyễn Over a year ago

Yes, I know one more information. I just fix my filter func to run that. thank you

marc_s · Accepted Answer · 2021-03-07 07:49:55Z

0

Sure not the best solution, but I would loop through each data object and filter the data array for each listId Object. Just like this:

data.forEach(element => {
  listId.forEach(removeId => {
    element.data = element.data.filter(e.id => e.id !== removeId);
  });
});

edited Mar 7, 2021 at 7:49

marc_s

760k186 gold badges1.4k silver badges1.5k bronze badges

answered Mar 3, 2021 at 13:38

blank42

13 bronze badges

2 Comments

Mike B Over a year ago

Doesn't work. You need to check e.id, not e itself. as each element of data array is an object

blank42 Over a year ago

You are absolutely correct did not see this

Collectives™ on Stack Overflow

Remove object in array by id javascript

4 Answers 4

Comments

Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related