MYSQL Node.js parse error and throw err error

Question

throw err; // Rethrow non-MySQL errors ^

Error: ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''a', 'b', 'c'' at line 1

(I had entered a as the name,b as the username and c as the password in the form)

I can't figure out where the problem is.

db.js:

function createUser(name, username, password){
    var sql = "INSERT INTO users (name,username,password) VALUES ?";
    var values = [name, username, password];
    con.query(sql, [values], function (err, result) {
      if (err) throw err;
      console.log('inserted');
    });
  }

  module.exports = {createUser};

relevant part of server.js:

app.post('/create', function(req,res) {
  db.createUser(req.body.name,req.body.username,req.body.password);
  res.status(200).send();
});

You nesting your values array inside another array.

Take-Some-Bytes
– Take-Some-Bytes

2020-08-29 21:22:57 +00:00
Commented Aug 29, 2020 at 21:22 — Take-Some-Bytes
– Take-Some-Bytes, Commented Aug 29, 2020 at 21:22

GMB · Accepted Answer · 2020-08-29 21:21:10Z

1

I think you just need additional square brackets around the values:

var sql = "INSERT INTO users (name,username,password) VALUES ?";
var values = [[name, username, password]];
con.query(sql, [values], function (err, result) { ... });

This mechanism is mostly meant to insert multiple rows. You could also separate the parameters:

var sql = "INSERT INTO users (name,username,password) VALUES (?, ?, ?)";
var values = [name, username, password];
con.query(sql, values, function (err, result) { ... });

answered Aug 29, 2020 at 21:21

GMB

224k25 gold badges103 silver badges151 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

jpj Over a year ago

The first one works, the second method gives the same error. Thanks though!

GMB Over a year ago

@jpj: the second code block should work too. Did you notice that I removed the square brackets around values in the query() call of the second code block?

nbk · Accepted Answer · 2020-08-29 23:37:08Z

0

You have to add for every variable a placeholder

function createUser(name, username, password){
    var sql = "INSERT INTO users (name,username,password) VALUES (?,?,?);";
    var values = [name, username, password];
    con.query(sql, values, function (err, result) {
      if (err) throw err;
      console.log('inserted');
    });
  }

  module.exports = {createUser};

edited Aug 29, 2020 at 23:37

answered Aug 29, 2020 at 21:21

nbk

49.6k8 gold badges32 silver badges53 bronze badges

Collectives™ on Stack Overflow

MYSQL Node.js parse error and throw err error

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related