Remove class from parent element javascript

Question

I have a container that opens via an onclick function. I then have a cross within the container that should close the parent element however I receive a

TypeError: undefined is not an object (evaluating 'parent.id')

Code is here

<div class="post" onclick="postClick(el)">
...
...
</div>

JavaScript

             function postClick(el) {
                     document.getElementById(el.id).classList.add("read");
             }
             function postClose(event) {
                 var parent = this.parentNode;
                 console.log(parent.id);
                 parent.id.classList.remove("read");         
             }

What does the console.log(parent.id); return?

AndrewL64
– AndrewL64

2020-08-04 21:16:21 +00:00
Commented Aug 4, 2020 at 21:16 — AndrewL64
– AndrewL64, Commented Aug 4, 2020 at 21:16
@AndrewL64 undefined

Mac
– Mac

2020-08-04 21:19:49 +00:00
Commented Aug 4, 2020 at 21:19 — Mac
– Mac, Commented Aug 4, 2020 at 21:19

Carolyn Hodges · Accepted Answer · 2020-08-04 21:18:37Z

4

Use event.target to get the reference to the HTML element. And you have an extra .id in the parent.id.classList expression.

function postClick(event) {
  const el = event.target;
  document.getElementById(el.id).classList.add("read");
}

function postClose(event) {
  const el = event.target;
  const parent = el.parentNode;
  console.log(parent.id);
  parent.classList.remove("read");         
 }

<div class="post" onclick="postClick(event)">
...
...
</div>

answered Aug 4, 2020 at 21:18

Carolyn Hodges

1816 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Mac Over a year ago

TypeError: undefined is not an object (evaluating 'event.target')

Carolyn Hodges Over a year ago

Your problem is related to extra id in parent.id.classList.remove ;)

Mac Over a year ago

I have parent.classList.remove("read"); as the last line and it is still returning TypeError: undefined is not an object (evaluating 'event.target')

NoNickAvailable · Accepted Answer · 2020-08-04 21:24:13Z

0

One way of doing this is using pure Javascript and bind the event listener like this

document.querySelector('#toggle').addEventListener('click', function (e) {
  console.log(this.parentNode.classList.remove('read'))
});

div {
  padding: 20px 50px;
}

div.read {
  background-color: red;
}

<div class="read">
  <button id="toggle">Remove Parent Class</button>
</div>

answered Aug 4, 2020 at 21:24

NoNickAvailable

3991 gold badge2 silver badges12 bronze badges

1 Comment

NoNickAvailable Over a year ago

If parent.id returns undefined then the parent probably has no id tag

THENETSPIDER · Accepted Answer · 2022-07-27 16:54:29Z

0

Jut use this and you are done : 😊

element.parentNode.classList.remove("class-name");

answered Jul 27, 2022 at 16:54

THENETSPIDER

3574 silver badges9 bronze badges

Comments

nikhil swami · Accepted Answer · 2020-08-07 16:24:03Z

-3

if the project is complex and needs interactivity more than often then you use jquery library for the interactivity.

//to remove class
$( "p" ).removeClass( "myClass yourClass" )


$("#div123").toggle(); //if you want to temp hide elements

as your code suggests the 'read' items must be disabled, you can toggle them once an event handler is wrapped over the toggle method. you can pass this or $(this) in case you want to do stuff with the owner of the function call.

well i agree some adept devs didnt like this answer, it will be surely of some help to some beginner dev in future who is looking for an alternative option to hide elements or remove classes

edited Aug 7, 2020 at 16:24

answered Aug 4, 2020 at 21:20

nikhil swami

2,70410 silver badges18 bronze badges

3 Comments

NoNickAvailable Over a year ago

Please don't ever again recommend jQuery (which is a huge library) for such a simple task.

Mac Over a year ago

I only have like 10 javascript functions on my whole site, I don't see a need for JQuery

nikhil swami Over a year ago

@mac my answer explains "Remove class from parent element javascript" adequately. it was intended to save developer time and reduce maintenance. if you are really comfy with native JS then its upto you.

Collectives™ on Stack Overflow

Remove class from parent element javascript

4 Answers 4

3 Comments

1 Comment

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

1 Comment

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related