Iterate through list to create new list with IDs Python

Question

So I am trying to use the IMDBpy module to connect a list of programs to their respective Genres. First I am trying to get a new list of their IMDB IDs to, from there, get their corresponding Genre. Unfortunately I am unable to iterate through my list of programs and generate a new list of corresponding IDs. Somehow my function gets stuck at the first iteration. What am I missing in my definition?

from imdb import IMDB
ia = IMDb()
programs = ['midsomer murders', 'wheeler dealers: dream car', 'solo: a star wars story (2018)']
def ids_list(x):
    ids = []
    for item in list(x):
        movie = ia.search_movie(item)[0].getID()
        for movie in movies:
            ids.append(movie)
        return ids
    
ids_list(programs)

output:

['0118401']

As you can see only the first item comes through, whereas my code suggests it should append every item in the list after running it through ia.search_movie(item)[0].getID(). Thanks in advance!

Yes just done that, now I get an IndexError: list index out of range — tivoo
– tivoo, Commented Jul 21, 2020 at 9:50
that would be on this line - ia.search_movie(item)[0] - sometimes you might not be getting any elements , so when you try to access 0-th element it throws error — Sowjanya R Bhat
– Sowjanya R Bhat, Commented Jul 21, 2020 at 9:53
use if len(ia.search_movie(item)): like so before that line — Sowjanya R Bhat
– Sowjanya R Bhat, Commented Jul 21, 2020 at 9:54

user120242 · Accepted Answer · 2020-07-21 11:39:12Z

1

Your return is indented incorrectly. It returns after the first iteration of the for loop:

from imdb import IMDb
ia = IMDb()
programs = ['midsomer murders', 'wheeler dealers: dream car', 'solo: a star wars story (2018)']
def ids_list(x):
    ids = []
    for item in list(x):
        movie = ia.search_movie(item)
        if movie:
          ids.append(movie[0].getID())
        else:
          ids.append(None)
    return ids
    
print(ids_list(programs))

shortened version using list comprehension and assignment operator (Python 3.8+):

from imdb import IMDb
ia = IMDb()
programs = ['midsomer murders', 'wheeler dealers: dream car', 'solo: a star wars story (2018)']
def ids_list(x):
    return [m[0].getID() if (m:=ia.search_movie(i)) else None for i in x]
    
print(ids_list(programs))

edited Jul 21, 2020 at 11:39

answered Jul 21, 2020 at 10:20

user120242

15.3k3 gold badges43 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

tivoo Over a year ago

Again syntax error in your code in (m:=ia.search_movie(i))

user120242 Over a year ago

shortened version requires python 3.8+. I'm guessing you are using an older version. You can use the top version

tivoo Over a year ago

Yes true I am, the top version is also giving me TypeError: quote_from_bytes() expected bytes I think it has to do with the search movie value not being a string.

user120242 Over a year ago

That would be a problem with the programs list, containing data you haven't shown. You should check the output in list programs. You could cast it to a string, but the real problem is your original list is malformed and needs to be fixed and the reason you are getting something other than strings found.

user120242 Over a year ago

also, are you sure you only want the first movie's ID found and not all the possible IDs found?

|

Sowjanya R Bhat · Accepted Answer · 2020-07-21 10:01:36Z

1

I mean change your for-loop code to this :

for item in list(x):
    if len(ia.search_movie(item)):
        movies = ia.search_movie(item)[0].getID()
        [ids.append(movie) for movie in movies]
return ids

answered Jul 21, 2020 at 10:01

Sowjanya R Bhat

1,18610 silver badges21 bronze badges

Collectives™ on Stack Overflow

Iterate through list to create new list with IDs Python

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related