How to set variable from callback function?

Question

I have function below.

function sh(cmd) {
    exec(cmd, (err, stdout, stderr) => {
      if (err) {
        console.log(err);
        std_value.flush();
        std_value.set("error");
      } else {
        console.log({stdout, stderr});
        std_value.flush();
        std_value.set(stdout);
        console.log('std_value in ' + std_value.result);
      }
    });
    console.log('std_value out ' + std_value.result);
    return std_value.result;
}

I want to sh(cmd) return output of cmd. So i am using the following(it is little bit shitty). But exec is async function, so outer std_value.result will be the value from last call. Is it normal way to create sh(cmd), which wiil return stdout or I should use promises?

Duplicate of How do I return the response from an asynchronous call? — Guy Incognito
– Guy Incognito, Commented Jun 19, 2020 at 9:50

Shihab · Accepted Answer · 2020-06-19 09:36:33Z

1

You can make use of promise here since you can not return value from the callback/async function.

function sh(cmd) {
  return new Promise((resolve, reject) => {
    exec(cmd, (err, stdout, stderr) => {
      if (err) {
        console.log(err);
        std_value.flush();
        std_value.set("error");
        reject(err);
      } else {
        console.log({stdout, stderr});
        std_value.flush();
        std_value.set(stdout);
        console.log('std_value in ' + std_value.result);

        resolve(std_value.result);
      }
    });
  })
}

sh().then(val => {
  console.log(val); //this should console the value of std_value.result
})

Note: I don't know where did you get std_value.

answered Jun 19, 2020 at 9:36

Shihab

2,6793 gold badges23 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Girish Sasidharan · Accepted Answer · 2020-06-19 09:39:52Z

1

function sh(cmd, callback) {
    exec(cmd, (err, stdout, stderr) => {
      if (err) {
        console.log(err);
        std_value.flush();
        std_value.set("error");
        if(!!callback) {
          callback(err);
        }
      } else {
        console.log({stdout, stderr});
        std_value.flush();
        std_value.set(stdout);        
        console.log('std_value in ' + std_value.result);
        if(!!callback) {
          callback(std_value.result);
        }
      }
    });
}

sh("run", function(result) {
  console.log(result);
});

You can implement the same with callback like this.

answered Jun 19, 2020 at 9:39

Girish Sasidharan

6021 gold badge6 silver badges15 bronze badges

Collectives™ on Stack Overflow

How to set variable from callback function?

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related