Bash/Shell script concatenate string in in while loop with field parameters while reading file

Question

I struggle to properly read a file which is nothing else than a key=value file.

This is the file:

#test.txt

global.project=99999 
global.env=pr
global.app=Terraform
global.dcs=CloudBroker
global.cbp=n/a

This is the code:

TS=""
while IFS== read -r f1 f2; do
    echo $f1
    echo $f2
    val=$f2
    TS+="\"${f1}\":\"${f2}\","

done < "tags.txt"

echo "${TS}" # Result: ","global.cbp":"n/audBroker

The result is very strange. When I remove f2, then no issues occur.

The expected result should be:

"global.opco":"99999","global.env":"pr" and so on.

I think your file has DOS line endings, fix that with dos2unix and try again — oguz ismail
– oguz ismail, Commented Jun 16, 2020 at 19:24
The test.txt file is in DOS/Windows format, and has a nonprinting carriage return character at the end of each line (in addition to the newline that unix programs expect), and it's getting treated as part of f2. See this question. In your case, you can trim it by changing the read command slightly: while IFS=$'=\r' read -r f1 f2; do. — Gordon Davisson
– Gordon Davisson, Commented Jun 16, 2020 at 19:25

WorkoutBuddy · Accepted Answer · 2020-06-16 21:35:29Z

1

Based on the comment by @GordonDavisson, I modified the script and it works now like a charm:


TS=""
while IFS=$'=\r' read -r f1 f2; do
    echo $f1
    echo $f2
    val=$f2
    TS+="\"${f1}\":\"${f2}\","

done < "tags.txt"

echo "${TS}" # Result: {"global.project":"99999","global.env":"pr","global.app":"Terraform","global.dcs":"CloudBroker","global.cbp":"n/a",}

answered Jun 16, 2020 at 21:35

WorkoutBuddy

7591 gold badge12 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

KamilCuk · Accepted Answer · 2020-06-16 21:41:57Z

1

Just a regex:

sed 's/\(.*\)=\(.*\)\r\?/"\1":"\2"/' tags.txt | paste -sd,
#                                                        ^ merge lines with comma
#                        ^  ^^^  ^     add some characters
# put  ^^^^^^             ^^           <- here
# put          ^^^^^^          ^^      <- here

answered Jun 16, 2020 at 21:41

KamilCuk

146k8 gold badges84 silver badges154 bronze badges

Collectives™ on Stack Overflow

Bash/Shell script concatenate string in in while loop with field parameters while reading file

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related