javascript validation for numbers

Question

can someone tell me what i am doing wrong here.. i am not getting invalid number alert when i enter 1 1 0r a

function validateNumeric() {
  var old_val = document.getElementById("tbNumber").value;
  var new_val = old_val.replace(/^\s+|\s+$/g,"");
  var validChars = '0123456789.'; 

  for(var i = 0; i < val.length; i++){ 
    if(validChars.indexOf(new_val.charAt(i)) == -1){
      alert('Please enter valid number');
      return false; 
    } else {
        document.getElementById("tbNumber").value = new_val;
      }
  }
  return true; 
}

Duplicate stackoverflow.com/questions/6228041/javascript-check-for-spaces ? — OnesimusUnbound
– OnesimusUnbound, Commented Jun 3, 2011 at 19:08
what was wrong with the top answer when you asked this before? — Matt
– Matt, Commented Jun 3, 2011 at 19:13

Alex · Accepted Answer · 2011-06-03 19:26:58Z

2

In your for loop test, you're referencing a variable val, which probably comes back as having a length of 0, so your loop will never do anything and the function will simply return true. I'm guessing your for loop should actually look like:

for(var i = 0; i < new_val.length; i++){
    ...
}

edited Jun 3, 2011 at 19:26

answered Jun 3, 2011 at 19:13

Alex

3,0993 gold badges27 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Adrian J. Moreno · Accepted Answer · 2011-06-03 19:35:17Z

0

There is a much simpler solution: use a regular expression.

Your valid characters are the digits 0 -9, including a decimal point, correct? Well, the RegEx for that is \d. Therefore, this would check if the value entered is numeric:

(/\d/).test( myValue );

Therefore, your code just needs to use the RegEx instead of an expensive loop.

function validateNumeric(){
    var x = document.getElementById('foo');
    var y = x.value.replace(/^\s+|\s+$/g,'');
    var DIGITS = (/\d/); // Uppercase because this is a constant value

    if (!DIGITS.test( y )){
        alert('Please enter a valid number.');
        return false;
    } else {
        x.value = y;
        return true;
    }
}

answered Jun 3, 2011 at 19:35

Adrian J. Moreno

14.9k1 gold badge41 silver badges46 bronze badges

1 Comment

jack Over a year ago

thanx for the help but if someone enter 2..2 than how can i test that

Collectives™ on Stack Overflow

javascript validation for numbers

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related