Generate array from comma-separated value string

Question

I have a string that is sent to my JavaScript via PHP that looks like this:

var string = "[ 'string 1','string 2 ','string 3' ]"

I want to split this string and get rid of the symbols [, ] and ' to produce the array

var array = {
    string 1, 
    string 2,
    string 3,
}

My current method uses a bunch of replaces, splits and loops. It seems very inefficient, and I want a better/more efficient method.

Arrays use [, not {.

SLaks
– SLaks

2011-06-01 00:27:02 +00:00
Commented Jun 1, 2011 at 0:27 — SLaks
– SLaks, Commented Jun 1, 2011 at 0:27

SLaks · Accepted Answer · 2011-06-01 00:27:34Z

5

It sounds like you're trying to parse a JSON string.

Use a JSON parser:

var array = JSON.parse(str);

For older browsers, you should include a JSON parser. (Newer browsers have it built-in)

answered Jun 1, 2011 at 0:27

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

tomfumb · Accepted Answer · 2011-06-01 00:41:44Z

3

What? Is everyone insane?!

var array = ['string 1', 'string 2', 'string 3'];

answered Jun 1, 2011 at 0:41

tomfumb

3,7693 gold badges38 silver badges51 bronze badges

3 Comments

Scott Over a year ago

the thing about doing that is the string gets read as individual characters like array[0] gives me [ and array[1] gives me '

tomfumb Over a year ago

@Scott - you're not supposed to split or otherwise parse this - this is JSON. If you output this exact line you will get a javascript array called 'array'

nnnnnn Over a year ago

+1 assuming the array 'string' is available when the page is first generated as compared to being returned from an Ajax call - which of course the OP didn't mention.

Tuco · Accepted Answer · 2011-06-01 00:32:15Z

2

You can use eval()...

var myArray = eval("['string 1', 'string 2', 'string 3']");
alert(myArray[0]);

answered Jun 1, 2011 at 0:32

Tuco

1,6301 gold badge15 silver badges18 bronze badges

4 Comments

McKayla Over a year ago

(new Function('return ' + myArray))

McKayla Over a year ago

@Scott It may work, but the other two answers are safer, more efficient, and more modern.

tomfumb Over a year ago

guys seriously, I don't mean to be a **** but this is not sensible (see my answer)

Tuco Over a year ago

You guys are right, eval() can be dangerous and if you are unsure about the source, I'd recommend going with JSON.

Jonathon · Accepted Answer · 2011-06-01 01:14:20Z

0

var array = string.split("','");
if(array.length == 1)
{
    //deal with empty or one element array
}
else{
    array[0] = array[0].substring(3);
    array[array.length() - 1] = array[array.length() - 1].substring(0, array[array.length() - 1].length() - 3);
}

answered Jun 1, 2011 at 1:14

Jonathon

2,6755 gold badges30 silver badges50 bronze badges

Collectives™ on Stack Overflow

Generate array from comma-separated value string

4 Answers 4

Comments

3 Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

3 Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related