0

I am just trying to push 2 different columns(name and sys_id) data into an array. I have totally 38 records with different data some duplicates also there.

When I try to insert as objects its inserting only one record details 38times.

0: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
1: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
2: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
3: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
4: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
5: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
6: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
7: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
8: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
9: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
10: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}
11: {name: "Incident Request", sys_id: "3ee543f61b363740f713ed7b2f4bcbc0"}

I have tried below script ,in item I will be getting all record details.

var arr=[];
var obj = {};

while(item.next()){
    obj["name"] = item.cat_item.name.toString();
    obj["sys_id"] = item.cat_item.sys_id.toString();
    arr.push(data.obj);
}

if I push only item.cat_item.name.toString() into an array directly am getting correct data.

0: "Manage AAA Devices"
1: ""
2: "Manage AAA - ISE Admin Functions"
3: "Manage AAA Devices"
4: "Manage AAA - ISE Admin Functions"
5: "SNOW Change Request"
6: ""
7: "Manage AAA - ISE Admin Functions"
8: "Manage AAA - ISE Admin Functions"
9: "Incident Request"
10: "Manage AAA - ISE Admin Functions"
11: "Incident Request"
12: "Incident Request"
13: "Server Lifecycle(EOL)"
14: "Incident Request"
15: "Server Lifecycle(EOL)"
16: "Incident Request"
17: "Incident Request"

only issue is while inserting as object. Is there anything wrong with my code? Can anyone help me?

Improve this question
3
  • Can you create a small demo for this using jsfiddle or snippet here to show the issue happening. Commented May 7, 2020 at 8:24
  • @palaѕн actually am using this script in servicenow side that is why I couldn't create any sample fiddle Commented May 7, 2020 at 8:28
  • You can use this: developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/… to create a dummy makeRangeIterator and return item.cat_item.name instead of just result.value to create the same scenario. Commented May 7, 2020 at 8:32

3 Answers 3

Reset to default
1

You are referencing the same object in every iteration and just changing it's attributes. Try creating a new object inside the while loop.

var arr=[];

while(item.next()){
    var obj = {};
    obj["name"] = item.cat_item.name.toString();
    obj["sys_id"] = item.cat_item.sys_id.toString();
    arr.push(data.obj);
}
Improve this answer
Sign up to request clarification or add additional context in comments.

Comments

1

The next() method returns an object with two properties: value, done

var arr=[];
var obj = {};
var index = item.next();

while (!index.done) {
    obj["name"] = index.cat_item.name.toString();
    obj["sys_id"] = index.cat_item.sys_id.toString();
    arr.push(data.obj);
    index = item.next();
}
Improve this answer

Comments

1

You need to create a new obj object for each iteration, so its declaration and initialization should go inside the loop:

const data = [
  { name: "Incident Request", sys_id: 1 },
  { name: "Incident Request", sys_id: 2 },
  { name: "Incident Request", sys_id: 1 },
  { name: "Incident Request", sys_id: 4 },
  { name: "Incident Request", sys_id: 2 },
  { name: "Incident Request", sys_id: 1 },
  { name: "Incident Request", sys_id: 2 },
  { name: "Incident Request", sys_id: 3 },
];

const arr = [];

data.forEach((item) => {
  const name = item.name.toString();
  const sys_id = item.sys_id.toString();
  
  // Check if there's already an entry for this `sys_id` and do nothing in that case:
  if (arr.find(cursor => cursor.sys_id === sys_id)) return;
  
  // Here we are not reusing a single object, but creating a new one on each iteration:
  arr.push({ name, sys_id });
});

console.log(arr.map(({ name, sys_id }) => `${ name } - ${ sys_id }`));
.as-console-wrapper {
  max-height: 100% !important;
}

Otherwise, you are always updating the same object and adding it to an additional position in arr. As all positions are referencing the same object, each update you do on it affects all of them, so you will only see the values of the last iteration repeated multiple times:

const data = [
  { name: "Incident Request", sys_id: 1 },
  { name: "Incident Request", sys_id: 2 },
  { name: "Incident Request", sys_id: 3 },
  { name: "Incident Request", sys_id: 4 },
  { name: "Incident Request", sys_id: 5 },
  { name: "Incident Request", sys_id: 6 },
  { name: "Incident Request", sys_id: 7 },
  { name: "Incident Request", sys_id: 8 },
];

const arr = [];
const obj = {};

data.forEach((item) => {
  // Update the existing object (always the same object):
  obj.name = item.name.toString(),
  obj.sys_id = item.sys_id.toString(),

  // And add it one more time to the array:
  arr.push(obj);
});

console.log(arr.map(({ name, sys_id }) => `${ name } - ${ sys_id }`));
.as-console-wrapper {
  max-height: 100% !important;
}

Improve this answer

3 Comments

How can I remove duplicate objects from this array?I tried ng-repeat="item in arr|unique:item.sys_id" .Its not working.can you please give some sugesstion?
You could only push new objects conditionally, checking first if there's already an entry with the same sys_id using Array.prototype.find().
thank you.anyways ng-repeat="item in arr | unique : 'name'" worked for me.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.