jQuery: Using replace() on value of input not working

Question

When the user selects YES in the membership dropdown, the value of the input should change from "service_######" to "membership##_####" which I have been trying to do with replace(), as well as make the change clearly visible to the user, but it stays the same both visually and when the form is sent.

<div class="col">
  <div class="form-group col-md-6">
    <label class="" for="membership">¿Membership?</label>
    <select name="membership" id="membership" class="form-control input-sm">
    <option value="0">NO</option>
    <option value="1">YES</option>
    </select>
  </div>

  <div class="form-group col-md-6">
    <label for="exampleInputEmail1" class="light-label">ID</label>
    <input type="text" class="form-control" name="invoice_id" id="invoice_id" value="service_id_19_0022" readonly>
  </div>
</div>

    $('#membership').change(function(e){
        if( $(e.target).val() == 1 ){
            changeServiceId();
        }
    });

    function changeServiceId(){
        $('#invoice_id').prop('readonly',false);
        var invoiceid = $('#invoice_id').val();
        console.log(invoiceid);

        var invoiceid = invoiceid.replace(/service/, 'membership');
        $('#invoice_id').attr('value').replace(/service/, 'membership');
        console.log(invoiceid);
        $('#invoice_id').prop('readonly',true);
    }

As you can see I tried both attr('value') as well as value() but it seems Im doing something wrong

palaѕн · Accepted Answer · 2020-04-28 15:05:24Z

2

The issue is you are not setting the value at all to #invoice_id. To set value we can simply use .val( value ) like:

var invoiceid = invoiceid.replace(/service/, 'membership');
$('#invoice_id').val(invoiceid);

Fiddle Demo

answered Apr 28, 2020 at 15:05

palaѕн

74.2k17 gold badges123 silver badges140 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David · Accepted Answer · 2020-04-28 15:06:02Z

0

You're over-thinking it here:

$('#invoice_id').attr('value').replace(/service/, 'membership');

First of all, you're not actually doing anything with the value that you're replacing. (.attr() returns a value, .replace() returns a value, ultimately that last returned value is just being ignored.) Second, use .val() to set a value. You can simplify to just this:

$('#invoice_id').val(invoiceid);

answered Apr 28, 2020 at 15:06

David

221k42 gold badges245 silver badges337 bronze badges

Comments

zb22 · Accepted Answer · 2020-04-28 15:11:53Z

0

You can set the value by either one of these:

$('#invoice_id').val(invoiceid);

or using attr() like you tried to do: $('#invoice_id').attr('value', invoiceid)

answered Apr 28, 2020 at 15:11

zb22

3,2413 gold badges22 silver badges38 bronze badges

Comments

Lalu Prajapati · Accepted Answer · 2020-04-28 15:16:45Z

0

Please find the modified code https://jsfiddle.net/un9v8xah/

You should change the value on dropdown change.
Thanks

answered Apr 28, 2020 at 15:16

Lalu Prajapati

112 bronze badges

Collectives™ on Stack Overflow

jQuery: Using replace() on value of input not working

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related