React Query String not being displayed

Question

I am using query-string to pass some parameters and render the below component

import React, { Component } from "react";
class Show extends Component {

  constructor(props,context) {
        super(props,context);
        this.state = {
          name: ''
        };
        console.log(this);

    }


  render() {
    return (
      <div>
        <h4>Hi {this.props.match.params.name} </h4>
        <p></p>
        {this.props.match.params.name ? <b>ID: {this.props.match.params.name}</b> : }
      </div>
    );
  }
}

export default Show;

The route is like below :

    <Route path='/show/:name?' component={Show} />

But this always results in undefined name and I see only Hi not the name .I use the below versions .

"react-dom": "^16.13.0",
"react-router-dom": "^5.1.2",
"query-string": "^6.11.1"

Not sure where I am making a mistake .Any help is appreciated.

Copy/pasted your code; I'm unable to repro. codesandbox.io/s/… — Drew Reese
– Drew Reese, Commented Apr 7, 2020 at 8:23
you can see that when I query xezlf.csb.app/show?name=james the name james doesn't show in the page like Hi james — Ricky
– Ricky, Commented Apr 7, 2020 at 8:48
I see, you've conflated match parameters with query parameters. — Drew Reese
– Drew Reese, Commented Apr 7, 2020 at 9:06

Drew Reese · Accepted Answer · 2020-04-07 08:55:47Z

1

You can query path query parameters from the location prop.

props.location.search

If route path is "/show/:name", the match prop will have the path parameter name, i.e. props.match.params.name, and any URL query parameters will simply be appended to the URL and can be found on the location prop.

Usage:

class Show extends Component {
  constructor(props, context) {
    super(props, context);
    this.state = {
      name: ""
    };
    console.log(this);
  }

  render() {
    return (
      <div>
        <h4>Math Param {this.props.match.params.name} </h4>
        <h3>Query {this.props.location.search} </h3>
        <p />
        {this.props.match.params.name && (
          <b>ID: {this.props.match.params.name}</b>
        )}
      </div>
    );
  }
}

answered Apr 7, 2020 at 8:55

Drew Reese

207k19 gold badges280 silver badges292 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

J.E.C. · Accepted Answer · 2020-04-07 09:23:47Z

Query string is used with a longer URL with something after the "?". If i type in localhost:3000/show/bob? the props.location object would have the pathname as /show/bob, so you don't really need it for this specific route.

I reproduced your code locally and wasn't getting 'undefined' for name, I was getting the expected output. Make sure that your App component routes are surrounded by a <Router> tag like this:

<Router>
     <Route path='/show/:name?' component={Show} />
</Router>

Also the if/else conditional in your show component needs something after the else operator. Either use && or add null after it.

If you're interested in hooks check out the useParams() hook here. It provides url parameters for you.

Collectives™ on Stack Overflow

React Query String not being displayed

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related