Syntax error while passing arguments to JavaScript function from Django template

Question

I have to pass 4 arguments from a Django template to a JavaScript function. Out of these 4, 3 are integers/decimals and 1 is a string.

<button onclick="addCart({{ item.id }}, {{ item.price }}, {{ item.discount }}, {{item.name}})">
               Add to cart
</button>

Here is the Javascript function.

let USER_CART = [];
function addCart(itemId, itemPrice, itemDiscount, itemName) {
    let itemQuantity = parseInt(document.getElementById(itemId).value);
    if (itemQuantity > 0) {
        let item_index = USER_CART.findIndex(item => item.id === itemId);
        if (item_index === -1) {
            let item = {
                id: itemId,
                price: itemPrice,
                discount: itemDiscount,
                quantity: itemQuantity,
                title: itemName,
            };
            USER_CART.push(item);
        } else {
            USER_CART[item_index].quantity += itemQuantity;
        }
    }
}

Whenever I click on the button this error shows up on the console.

SyntaxError: missing ) after argument list

Another interesting thing is if I remove the item.name and itemName completely from the code, it works just fine.

You need to wrap the string argument in (single) quotes: '{{ item.name }}' With errors like this, always check the source code in the browser first (Ctrl+U). — user5734311
– user5734311, Commented Feb 8, 2020 at 10:36
@ChrisG Yes. I should have checked the generated HTML first, I was too focused on the JavaScript part. — Chandan Mahto
– Chandan Mahto, Commented Feb 8, 2020 at 10:45

Nafees Anwar · Accepted Answer · 2020-02-08 10:36:04Z

1

You need to add quotes around {{item.name}}.

<button onclick="addCart({{ item.id }}, {{ item.price }}, {{ item.discount }}, '{{item.name}}')">
               Add to cart
</button>

answered Feb 8, 2020 at 10:36

Nafees Anwar

6,6783 gold badges28 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Syntax error while passing arguments to JavaScript function from Django template

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related