Only matching when a string contains ALL characters specified in RegExp

Question

I'm trying to build a simple validator that will match [email protected] but not John@gmailcom or Johngmail.com - it must contain both @ and .

I am using this - /[@.]/g but it matches and tests when only one of these characters are matched.

Is there a better method of doing this?

Not the final solution, but one step closer : ^[[email protected]]{14}$ (I assumed chars can be shuffled because else that would be a strict equality withtout the neeed of a regexp) — challet
– challet, Commented Jan 22, 2020 at 15:45
If '@' followed by dot is the only check you perform for valid e-mail, @. happen to be valid e-mail either. — Yevhen Horbunkov
– Yevhen Horbunkov, Commented Jan 22, 2020 at 15:47
@UlysseBN I can admit it's only a partial answer but how is that friendly or unfriendly ? By the way, when I talk about what I see, you talk about what you assume is in the mind of someone else, please check yourself about friendlyness. — challet
– challet, Commented Jan 22, 2020 at 16:07
@challet I'm really confused. I definitely thought your comment was ment as a joke, seeing that you forced the check on any character included in [email protected], fourteen times, when OP was only talking about @ and .. And your explanation wasn't there as well. I'll just remove my comment, sorry for the trouble. — Ulysse BN
– Ulysse BN, Commented Jan 22, 2020 at 16:22

Ulysse BN · Accepted Answer · 2020-01-22 15:54:31Z

1

The issue with your regexp is that [] will tell whether one of @ or . is present.

If order matters, and you want @ to preceed ., you could use:

@.*\.

This will match any string that has @ and . with any character between them.

If order doesn't matter, I guess there is really no need for a Regexp:

myString.includes('@') && myString.includes('.')

The regexp version is available on regex101 so you can see details.

edited Jan 22, 2020 at 15:54

answered Jan 22, 2020 at 15:45

Ulysse BN

11.7k7 gold badges64 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Ulysse BN Over a year ago

@MonkeyZeus you are definitely right, and I guess it would be hard for a regexp to not care about order. Except with a trick like sorting the string before. I'll just delete this bit :)

Ulysse BN Over a year ago

@MonkeyZeus you should read again my answer... OP didn't ask for @ to preceed ., hence my proposition is saying if order matters and if order doesn't matter. If OP wanted a real email validation, there are a lot more parameters to take into account anyway.

Reikon Over a year ago

@UlysseBN- thanks, totally fixed the issue. Basic error from my end! Has to be a regex I think as I'm using data from an external source that will change, so for futureproofing it needs to handle more then just emails. After implementing what you suggested it now works on other stuff too. Thanks!

Collectives™ on Stack Overflow

Only matching when a string contains ALL characters specified in RegExp

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related