How call async method from non async web API

Question

I am having web api, which is non async.

From that web api, i am calling method

SmtpClient.SendMailAsync(email);

This email get sent to respective person, but the next web api request get fails.

public class TestController : ApiController
{
    public TestController(TestService testService)
    {
       _testService = testService;
    }

    public IHttpActionResult Post(data)
     {
         _testService.SendEmail(data);
     }
}

public class TestService 
{
    public async Task SendEmail(MailMessage email)
     {
        SmtpClient client = new SmtpClient();
        client.SendMailAsync(email)
     }
}

Usually there is still a non-Async Method. In this case, SendMail rather then SendMailAsync. — Christopher
– Christopher, Commented Nov 14, 2019 at 5:38
replace _testService.SendEmail(data); with _testService.SendEmail(data).GetAwaiter().GetResult() — ravi kumar
– ravi kumar, Commented Nov 14, 2019 at 5:48
@ravikumar: I don't want to wait till email sent, i want behavior like fire and forget. — Hemant Malpote
– Hemant Malpote, Commented Nov 14, 2019 at 6:12
@HemantMalpote: note, that SmtpClient must be disposed. Wrap it into using. — Dennis
– Dennis, Commented Nov 14, 2019 at 7:46

Christopher · Accepted Answer · 2019-11-14 05:43:26Z

1

From the days before the async/await pattern was introduced, there are still many non-asychronous functions around in Framework classes.

SmtpClient client is one of the classes old enough for this. The SendFunction are the droids you are look for:

https://learn.microsoft.com/en-us/dotnet/api/system.net.mail.smtpclient.send

While the naming is a bit off and they return void, those seems to be the pre-async functions. Failure should be communicated via Exceptions in both cases.

answered Nov 14, 2019 at 5:43

Christopher

9,8442 gold badges19 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sossenbinder · Accepted Answer · 2019-11-14 07:38:03Z

1

Given your comment that you want to have SendEmail behave like fire & forget, I would propose using

Task.Run(() => _testService.SendEmail(data));

This will give the unit of work to the threadpool and free your request from the duty of waiting for this task. Generelly this is advised for fire & forget.

As a rule of thumb otherwise, it's generally a bad idea to call asynchronous things from a synchronous context. Do async all the way, or be prepared for deadlocking. For example, you could simply make your controller actions asynchronous as well.

answered Nov 14, 2019 at 7:38

Sossenbinder

5,3707 gold badges48 silver badges92 bronze badges

1 Comment

Dennis Over a year ago

In this particular case it's OK to call some async stuff in fire-and-forget way from synchronous code.

Aleksandr Zolotov · Accepted Answer · 2019-11-14 10:29:51Z

0

If you will need use some result of sending:

    public async IHttpActionResult Post(data)
 {
     var t = Task.Run(() =>_testService.SendEmail(data));

     var result = await t;
     // do something with result
 }

- but of course your SendEmail function should return Task<> instead of Task ...

answered Nov 14, 2019 at 10:29

Aleksandr Zolotov

1,1303 gold badges20 silver badges33 bronze badges

Collectives™ on Stack Overflow

How call async method from non async web API

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related