Remove numbers from a comma separated string in javascript when checked is false

Question

I have some inputs by type checkbox:

<input type="checkbox" value="5da1dc651d011c56ef1cb3db_693715"  onchange="handlechange(this)">
<input type="checkbox" value="6da1dc651d011c56ef1cb3db_123689"  onchange="handlechange(this)">

handlechange() function is going to add the values of input checkedin

<input type="hidden" value="" class="GetVals" />

The main problem is that when checked is false the value of that input should be removed of <input type="hidden" value="" class="GetVals" />, but it would not remove.

function handlechange(a) {
  var check = $(a).prop("checked");
  if (check == true) {
    var value = $(a).val();
    ids += value + ','

  } 
  else if (check == false) {
    var elements = ids.substring(0, ids.lastIndexOf(","))
    var element = elements.split(",");
  }
  $(".GetVals").val(ids)
}

Mamun · Accepted Answer · 2019-11-09 14:54:03Z

2

You can achieve the result by using some built-in methods.

You can use .map() only on the checked check boxes with .get() and join() like the following way:

function handlechange() {
  var ids = $('input:checked').map((i, chk) => chk.value).get().join();
  $(".GetVals").val(ids)
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<input type="checkbox" value="5da1dc651d011c56ef1cb3db_693715"  onchange="handlechange(this)">
<input type="checkbox" value="6da1dc651d011c56ef1cb3db_123689"  onchange="handlechange(this)">

<input class="GetVals" style="width:500px;"/>

edited Nov 9, 2019 at 14:54

answered Nov 9, 2019 at 14:38

Mamun

69k9 gold badges51 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ibrahim mahrir Over a year ago

Beat me to it :-) . BTW, you don't need the parameter a anymore & in onchange="handlechange(this)"

sugars · Accepted Answer · 2019-11-09 14:43:25Z

0

function handlechange() {
  var ids = [];
  $(".checkbox").each(function() {
    if ($(this).prop("checked")) {
      ids.push($(this).val());
    }
  });
  $(".GetVals").val(ids.join(","));
  $("#vals").text(ids.join(","));
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>

<input class="checkbox" type="checkbox" value="5da1dc651d011c56ef1cb3db_693715" onchange="handlechange()">
<input class="checkbox" type="checkbox" value="6da1dc651d011c56ef1cb3db_123689" onchange="handlechange()">
<input type="hidden" value="" class="GetVals" />
<div id="vals"></div>

You can use each to loop the checkbox and then join all values which are checked.

answered Nov 9, 2019 at 14:43

sugars

1,4939 silver badges19 bronze badges

Collectives™ on Stack Overflow

Remove numbers from a comma separated string in javascript when checked is false

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related