Javascript how to pass variable to URL query with window.open

Question

First of all - this question has no answers at Include variable in URL or How can I do string interpolation in JavaScript? I tested many variants from elsewhere before my question here. For example, as advised at Include variable in URL

window.open('http://example.com/?q="+ myname"');

does not work with the script below. A kind of specific wrapping is needed.

So, simplest script

<script type="text/javascript">
function sendquery() {
var myname = "John";
alert(myname);
window.open('http://example.com/?q=(myname)');
}
</script>
<button onclick="sendquery()">Query</button>

Alert perfectly shows variable John. But query sends not variable John but (myname).

Or + myname - if follow other answers.

How to wrap variable to URL query ?

Basic string concatenation. window.open('http://example.com/?q='+ myname); — epascarello
– epascarello, Commented Oct 30, 2019 at 20:57

Josh G · Accepted Answer · 2019-10-30 20:56:10Z

2

It looks like you're just putting the variable in the string incorrectly. Check out template literals if you don't need to support IE.

var myname = "John";
// won't work
window.open('http://example.com/?q="+ myname"');
// will produce 'http://example.com/?q=John'
window.open(`http://example.com/?q=${myname}`);

and likewise

// won't work
window.open('http://example.com/?q=(myname)');
// valid
window.open(`http://example.com/?q=${myname}`);

If you do need to support IE then window.open('http://example.com/?q=' + myname); should work

answered Oct 30, 2019 at 20:56

Josh G

6449 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Serge Over a year ago

Thx everybody for hint, I've sorted many similar variations but not literal ! Solved and work with Microsoft Edge, at-least...

Mike Ezzati · Accepted Answer · 2019-10-30 21:42:03Z

1

Your string concatenation is not correct

var myname = "test"
window.open("http://example.com/?q=" + myname); // Classic string concatenation
window.open(`http://example.com/?q=${myname}`); // Using template literal

edited Oct 30, 2019 at 21:42

answered Oct 30, 2019 at 20:50

Mike Ezzati

3,1761 gold badge25 silver badges34 bronze badges

2 Comments

Serge Over a year ago

Thx for hint, I've sorted many similar variations but not literal ! Solved !

Serge Over a year ago

You were first :)

Anand G · Accepted Answer · 2019-10-30 20:52:23Z

1

You have to wrap the URL in Template Literals

window.open(`http://example.com/?q=${myname}`);

answered Oct 30, 2019 at 20:52

Anand G

3,2102 gold badges24 silver badges30 bronze badges

3 Comments

Scott Marcus Over a year ago

You don't "have to". You can use simple concatenation.

Anand G Over a year ago

Well "have to" should be "Should have to". The cleanest way of doing concatenation is the Template Literals

Scott Marcus Over a year ago

That's an opinion. I think a + "test" is cleaner than a${test} (<-- not sure how to put back-tick in an SO comment so that it actually appears as opposed to formats the contents as code).

Collectives™ on Stack Overflow

Javascript how to pass variable to URL query with window.open

3 Answers 3

1 Comment

2 Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related