How do I add a table row with this jquery script?

Question

I have a script that converts a select list into a table of checkboxes;

$('#edit-taxonomy-1').parent().append('<table id="checkboxes"><tbody><tr></tr></tbody></table>');

$('#edit-taxonomy-1 option').each(function() {
    var label = $(this).html();
    var value = $(this).attr('value');
    var ind = $(this).index();
    if (ind % 3 === 0  ) {
        $('#checkboxes tbody').append('</tr><tr><td><input type="checkbox" value="&#039;+value+&#039;">' + label + '</td>');
    }
    else {
        $('#checkboxes tbody').append('<td><input type="checkbox" value="&#039;+value+&#039;">' + label + '</td>');
    }
});

$('#edit-taxonomy-1').replaceWith($("#checkboxes"));

However I cannot get every third element to show up in a new row nicely.

Here is a fiddle: http://jsfiddle.net/cxVhz/
It shows what I have and what I want

In case you didn't get the comment warning here's how I would have done it: jsfiddle.net/cxVhz/38 — Richard Marskell - Drackir
– Richard Marskell - Drackir, Commented Apr 25, 2011 at 17:46

hunter · Accepted Answer · 2011-04-25 18:01:30Z

4

I think append() is doing things behind the scenes that might be "fixing" your html for you before it appends it.

Try this similar approach:

var tr = "";
$('#edit-taxonomy-1 option').each(function() {
    var label = $(this).html();
    var value = $(this).attr('value');
    var ind = $(this).index() + 1;

    // continually build your checkbox and label
    var checkbox = '<input type="checkbox" value="&#039;' + value + '&#039;" />' 
        + label;

    // keep adding to your tr
    tr += "<td>" + checkbox + "</td>";
    if (ind % 3 == 0) {
        // append the tr and clear its value
        $('#checkboxes tbody').append('<tr>' + tr + '</tr>');
        tr = "";
    }
});

// if ind % 3 was never hit above, output what is within tr
if (tr != "")
{
    $('#checkboxes tbody').append('<tr>' + tr + '</tr>');
}

working example: http://jsfiddle.net/cxVhz/18/

super updated solution:

$('#edit-taxonomy-1').parent().append('<table id="checkboxes"><tbody></tbody></table>');

$('#edit-taxonomy-1 option').each(function(index) {
    var $this = $(this);
    if (index % 3 === 0  ) {
        $('#checkboxes tbody').append('<tr></tr>');
    }
    $('#checkboxes tbody tr:last').append('<td><input type="checkbox" value="&#039;' + $this.val() + '&#039;" />' + $this.html()+ '</td>');
});

$('#edit-taxonomy-1').replaceWith($("#checkboxes"));

working example: http://jsfiddle.net/cxVhz/40/

edited Apr 25, 2011 at 18:01

answered Apr 25, 2011 at 15:51

hunter

63.7k19 gold badges115 silver badges115 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

g19fanatic Over a year ago

this is the correct answer. I was doing the same thing in jsfiddle. Here was my solution... +1 for doing it faster than me :) jsfiddle.net/cxVhz/24

Richard Marskell - Drackir Over a year ago

Yeah, you need to put valid HTML in there or the browser may do strange things to fix it. You have to think of the DOM as the DOM and not as HTML. (ie. You can't just throw opening and closing tags in there, you have to add elements to the parent element.) Here's my solution with jQuery and some other additions: jsfiddle.net/cxVhz/27

hunter Over a year ago

I thought so, too, until I saw suhairs answer, which is the most correct answer

hunter Over a year ago

@Drackir nice solution as well and even more elegant and straight forward

Richard Marskell - Drackir Over a year ago

Thanks. :) There are actually a bunch of ways the OPs code could be improved but I suppose it's outside of the scope of the question. :P

|

suhair · Accepted Answer · 2011-04-25 16:29:07Z

1

Here is the quick and just working update without refactoring the code. http://jsfiddle.net/cxVhz/22/ Edit: The tr inside the table declaration is not needed. Replace it with

$('#edit-taxonomy-1').parent().append('<table id="checkboxes"><tbody></tbody></table>');

updated link: http://jsfiddle.net/cxVhz/34/

edited Apr 25, 2011 at 16:29

answered Apr 25, 2011 at 15:54

suhair

11k11 gold badges56 silver badges63 bronze badges

2 Comments

hunter Over a year ago

I dig this answer the most. Nice use of :last and more logical. +1

Steve Kelly Over a year ago

be sure to still remove the extra empty TR at the beginning

Steve Kelly · Accepted Answer · 2011-04-25 15:55:42Z

0

The previous examples had extra TR's, so I thought you might want to see this solution. Good luck: http://jsfiddle.net/cxVhz/23/

answered Apr 25, 2011 at 15:55

Steve Kelly

3733 silver badges17 bronze badges

Comments

ChrisThompson · Accepted Answer · 2011-04-25 15:58:23Z

0

It looks as though you are appending a TD straight to the table body and not to a table row:

 $('#checkboxes tbody').append('<td><input type="checkbox" value="&#039;+value+&#039;">' + label + '</td>');

EDIT:

    var row = $('<tr></tr>');
    $('#edit-taxonomy-1 option').each(function() {
        var label = $(this).html();
        var value = $(this).attr('value');
        var ind = $(this).index();
        if (ind % 3 === 0  ) {
            $('#checkboxes tbody').append(row);
            row = $('<tr></tr>');
            var td = $('<td><input type="checkbox" value="&#039;+value+&#039;">' + label + '</td>');
            row.append(td);
        }
        else {
            $('<td><input type="checkbox" value="&#039;+value+&#039;">' + label + '</td>').appendTo(row);
        }
    });
    if(row.html().length>0){
        $('#checkboxes tbody').append(row);
    }

edited Apr 25, 2011 at 15:58

answered Apr 25, 2011 at 15:45

ChrisThompson

2,00813 silver badges17 bronze badges

1 Comment

Linens Over a year ago

yea i know but if I do $('#checkboxes tbody tr') it duplicates the entries

josh.trow · Accepted Answer · 2011-04-25 16:04:56Z

0

This JS works.

$('#edit-taxonomy-1 option').each(function() {
    var label = $(this).html();
    var value = $(this).attr('value');
    var ind = $(this).index();
    if (ind % 3 === 0) {
        $('#checkboxes tbody').append('<tr></tr>');
    }
    $('#checkboxes tbody tr:last-child').append('<td><input type="checkbox" value="&#039;+value+&#039;">' + label + '</td>');
});

answered Apr 25, 2011 at 16:04

josh.trow

4,90123 silver badges31 bronze badges

Collectives™ on Stack Overflow

How do I add a table row with this jquery script?

5 Answers 5

11 Comments

2 Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

11 Comments

2 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related