Javascript cleanest way to distinct array based on object property

Question

So I have an array of statuses and I want to get distinct values based on an element property ProductOrderStatusTypeID. I have one implementation but I want the cleanest way of doing that.

My list:

[{
  StatusID : 1,
  Name : "Open",
  ProductOrderStatusType : 'Initial'
  ProductOrderStatusTypeID : 1
},{
  StatusID : 3,
  Name : "Closed",
  ProductOrderStatusType : 'Final'
  ProductOrderStatusTypeID : 2
},
{
  StatusID : 3,
  Name : "Pending",
  ProductOrderStatusType : 'Initial'
  ProductOrderStatusTypeID : 1
}]

Expected output:

[{
  ProductOrderStatusType : 'Initial',
  ProductOrderStatusTypeID : 1
},{
  ProductOrderStatusType : 'Final',
  ProductOrderStatusTypeID : 2
}]

My code:

function getDistinctProductOrderStatusType(statuses) {
    return statuses.reduce(function (result, status) {
        var existingStatus = result.filter(function (res) {
            return res.ProductOrderStatusTypeID === status.ProductOrderStatusTypeID;
        })[0];
        if (!existingStatus) {
            result.push({
                ProductOrderStatusTypeID: status.ProductOrderStatusTypeID,
                ProductOrderStatusType: status.ProductOrderStatusType
            });
        }
        return result;
    }, []);
}

Probably best suited for codereview.stackexchange.com - since your code works but you want a suggestion to make it different. — Roko C. Buljan
– Roko C. Buljan, Commented Jul 16, 2019 at 20:12
Reducing to an object or Map using the "groupBy" values as keys is a lot more efficient than running filter() each iteration... then get values from that object — charlietfl
– charlietfl, Commented Jul 16, 2019 at 20:26
Statuses is array that i have mentioned in my question as 'My List' — Wamiq Rehman
– Wamiq Rehman, Commented Jul 16, 2019 at 20:29

Roko C. Buljan · Accepted Answer · 2019-07-16 22:35:11Z

const stat = [{
    StatusID: 1,
    Name: "Open",
    type: 'Initial', // !!! I renamed properties for simplicity sake
    typeID: 1
  }, {
    StatusID: 3,
    Name: "Closed",
    type: 'Final',
    typeID: 2
  }, {
    StatusID: 3,
    Name: "Pending",
    type: 'Initial',
    typeID: 1
  }
];

const distinctStat = arr => arr.reduce((a, {type, typeID}) =>
  a.some(ob => ob.typeID === typeID) ? a : a.concat({type, typeID})
, []);

console.log( distinctStat(stat) );

In case you find it more easier to name the properties you're not interested in collecting (like i.y.e: StatusID and Name) than you could go for the rest element:

const distinctStat = arr => arr.reduce((a, {StatusID, Name, ...r}) =>
  a.some(ob => ob.typeID === r.typeID) ? a : a.concat(r)
, []);

(same output as above)

Info:

Although we could, in the above code Array.prototype.some() is used instead of Array.prototype.find() because we don't need to return the entire object but just a boolean (as quickly as possible).

Collectives™ on Stack Overflow

Javascript cleanest way to distinct array based on object property

1 Answer 1

Info:

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Info:

Comments

Your Answer

Sign up or log in

Post as a guest

Related