Passing 'If statement' problem in Shell Scripting

Question

I'm developing simple terminal based application that helps to compile your C/C++ and Python source files in a one command. But when I execute the function like 'erun test.py' It's always gives the output: ERun: file unknown file extension.

For my opinion the problem at the if statement. I try to edit these statements but nothing is changed. Here is my source code:

#/bin/bash
# function ERun for C/C++ and python
# version 1.0

SAVEIFS=$IFS
IFS=$(echo -en "\n\b")

function erun {
    if [ -z "$1" ]; then
        #display usage if no paramters given
        echo "Usage: erun file.c/.cpp/.py"
        echo "Run: ./file"
    else
        for n in "$@"
        do
            if [ -f "$n" ] ; then
                case "$n{n%,}" in
                    *.py)
                    chmod +x "$n"       ;;
                    *.c|*.cpp)
                    gcc "$n" -o "$n"    ;;
                    *)
                    echo "ERun: '$n' unknown file extension"

                    return 1
                    ;;        
            esac
        else
            echo "'$n' - file does not exist."
            return 1
        fi
    done
 fi
}

IFS=$SAVEIFS

My expected output is getting a executable file. I'll be happy if you can help me. By the way if you want to contribute my this tiny project here is the project link: https://github.com/lvntky/ERun/ :)

A good first troubleshooting step is to run ShellCheck on a bad script. In this case it automatically flags both the bad shebang and the fact that the case patterns will never match — that other guy
– that other guy, Commented May 15, 2019 at 18:23

choroba · Accepted Answer · 2019-05-15 18:10:33Z

1

This is weird

"$n{n%,}"

For ab/program.py, it returns ab/program.py{%n,}.

You probably wanted something like

"${n,,}"

instead which turns all the uppercase letters to lowercase.

answered May 15, 2019 at 18:10

choroba

245k27 gold badges221 silver badges304 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user268396 Over a year ago

This is the first fix, but not sufficient because the if statement surrounding the case block is not properly closed by a corresponding fi either.

GoinOff Over a year ago

How is it not properly closed? fi for it is before the done for the for loop. Spacing in the code is a bit funky though.

Gordon Davisson Over a year ago

The indentation is wrong starting with the esac line, so it looks wrong, but the various close keywords actually match up.

Collectives™ on Stack Overflow

Passing 'If statement' problem in Shell Scripting

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related