How to minimize sorting runtime complexity?

Question

i wrote an application which is a custom console that allows execution of various commands. One of the commands allows sorting an array of integers. The input data is a string, which is a list of comma separated numbers.

My question is - how to minimize the sorting code runtime complexity as much as possible?

using System;
using System.Collections.Generic;
using CustomConsole.Common;
namespace Shell_Commander.Commands
{
class SortCommand : ICommand
{

    private string _sortCommandName = "sort";
    public string Name { get { return this._sortCommandName; } set { _sortCommandName = value; } }


    public string Execute(string parameters)
    {
        var splittedParameters = parameters.Split(",",StringSplitOptions.RemoveEmptyEntries);
        var arr = new List<int>();

        int number;
        int parameterIndex = 0;

        foreach (var item in splittedParameters)
        {
            parameterIndex++;

            if (int.TryParse(item, out number))
            {
                arr.Add(number);
            }
            else
            {
                Console.WriteLine($"The {parameterIndex}'st parameter isn't a number. Value: '{item}'.");
            }
        }

        int temp = 0;

        for (int write = 0; write < arr.Count; write++)
        {
            for (int sort = 0; sort < arr.Count - 1; sort++)
            {
                if (arr[sort] > arr[sort + 1])
                {
                    temp = arr[sort + 1];
                    arr[sort + 1] = arr[sort];
                    arr[sort] = temp;
                }
            }
        }
        var result = "";

        Console.Write("The sort result is: ");
        for (int i = 0; i < arr.Count; i++)
        {
            result += arr[i] + " ";
            Console.Write(arr[i] + " ");
        }

        Console.WriteLine();
        return result;
    }
}

}

Example - for the '4,1,2' input, the output will be:

"The sort result is: 1 2 4".

Are you talking about the little swap sort routine that you have in the code? — Black Frog
– Black Frog, Commented May 4, 2019 at 19:20
Use efficient sorting algorithm, like QuickSort? Use sorting from standard library? — user2956272
– user2956272, Commented May 4, 2019 at 19:23

Yurii N. · Accepted Answer · 2019-05-04 19:24:52Z

2

You need to read this and that. In fact, you can simply use LINQ's OrderBy method, which is internally using QuickSort.

So, here's the solution, instead of double for, use this:

var sortedArray = arr.OrderBy(x => x).ToArray();

answered May 4, 2019 at 19:24

Yurii N.

5,72112 gold badges45 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user2956272 Over a year ago

Why not just Array.Sort?

Yurii N. Over a year ago

@dyukha it's up to you, choose any of the already existing in C# sort functions.

Black Frog · Accepted Answer · 2019-05-04 19:25:32Z

1

Why not just replace your little sorting routine with calling the Sort method on array variable.

arr.Sort();

answered May 4, 2019 at 19:25

Black Frog

11.7k1 gold badge37 silver badges67 bronze badges

Collectives™ on Stack Overflow

How to minimize sorting runtime complexity?

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related