Return Largest 3-Digit Chunk From String - JavaScript

Question

I don't understand why this is returning zero:

function largestOfThree (num) {
    let stringyNums = num.toString();
    let highest = 0;

    for (let i = 0; i <= stringyNums.length - 3; i++) {
        let chunk = stringyNums.slice(i, i + 3);
        console.log(chunk);
        if (chunk > highest) chunk = highest;
    }
    return highest;
}
console.log(largestOfThree(123456789));

It seems as though chunk is not getting assigned to highest. I want to assign the new chunk to highest as we're looping through the stringyNums, every time it's greater than the existing highest chunk.

The function should return 789, in this case.

If chunk is a string, what does chunk > highest actually do? — John Coleman
– John Coleman, Commented Apr 22, 2019 at 19:21
I don't know if that is the issue, but it is a potential thing to be careful with — John Coleman
– John Coleman, Commented Apr 22, 2019 at 19:23

Void Spirit · Accepted Answer · 2019-04-22 19:22:20Z

4

You are not setting highest to chunk Change

if (chunk > highest) chunk = highest;

To

if (chunk > highest) highest = chunk ;

answered Apr 22, 2019 at 19:22

Void Spirit

9091 gold badge6 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Devan Allara · Accepted Answer · 2019-04-22 19:25:24Z

3

It's because of this line

if (chunk > highest) chunk = highest;

You're assigning chunk to highest instead of assigning highest to the largest chunk. Simply reverse the two variables and you're good to go.

if (chunk > highest) highest = chunk;

answered Apr 22, 2019 at 19:25

Devan Allara

642 bronze badges

Comments

Dennis Vash · Accepted Answer · 2019-04-22 19:51:06Z

2

For reference you can accomplish this with a more readable form of a one-liner (6-liner?):

const largestOfThree = num =>
  num
  .toString()
  .match(/.{1,3}/g)
  .map(Number)
  .reduce((acc, curr) => (acc > curr ? acc : curr));

console.log(largestOfThree(123456789));

edited Apr 22, 2019 at 19:51

answered Apr 22, 2019 at 19:29

Dennis Vash

54.2k12 gold badges120 silver badges133 bronze badges

1 Comment

John Coleman Over a year ago

Nice (+1) but one could quibble with this being described as a "one-liner". I count 6.

Masuk Helal Anik · Accepted Answer · 2019-04-22 19:29:30Z

1

Try this. You are assigning chunk=highest which is wrong

function largestOfThree (num) {

    let stringyNums = num.toString();
    let highest = 0; 
    for (let i = 0; i <= stringyNums.length - 3; i++) {

        let chunk = stringyNums.slice(i, i + 3);
        console.log(chunk);
        if (chunk > highest) highest=chunk; <---the error was here

    }

    return highest;

}

console.log(largestOfThree(123456789));

answered Apr 22, 2019 at 19:29

Masuk Helal Anik

2,28624 silver badges31 bronze badges

Comments

pbachman · Accepted Answer · 2019-04-22 19:31:14Z

1

largestOfThree(num: number): number {
    const stringyNums = num.toString();
    let highest = 0;
    for (let i = 0; i <= stringyNums.length - 3; i++) {
      let chunk = parseInt(stringyNums.slice(i, i + 3));
      if (chunk > highest) highest = chunk;
    }
    return highest;
}

answered Apr 22, 2019 at 19:31

pbachman

1,0692 gold badges13 silver badges23 bronze badges

Collectives™ on Stack Overflow

Return Largest 3-Digit Chunk From String - JavaScript

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related