Problem with comparing dates in javascript

Question

HI,

I have the following code that is supposed to compare two dates:

 var d = ($('#day').val());
 var m = ($('#month').val() -1);
 var y = $('#year').val(); 
 var birthdate = new Date(y,m,d);
 alert('birthdate is' + birthdate);
 var today = new Date();
 alert('today is'+ today); 
 var diff = (today - birthdate);
 years = Math.floor(diff/(1000*60*60*24*365));
 alert(years);

It's basically working but I'm interested to see if the date of birth makes the user over 18 or not. So I've tried to put in 30th march 1993 - which would make the user 17. I'm alerting out the birthdate and it gives me back the correct date (mon mar 29 1993 00:00:00 GMT + 0100 BST)....however this is evaluating to 18 (alert(years) in the above code) when it should evaluate to seventeen. It's not until I put in 3rd April 1993 that it evaluates to 17.

Any ideas?

See the great source of all knowledge for more information about calendar years. — Chris Shouts
– Chris Shouts, Commented Mar 29, 2011 at 13:37

Marcel Jackwerth · Accepted Answer · 2011-03-29 13:34:05Z

2

You have to mind leap-years, timezones... before reinventing the wheel, I recommend that you use DateJS.

if((18).years().ago().isBefore(birthdate)) {
  // handle underage visitors
}

answered Mar 29, 2011 at 13:34

Marcel Jackwerth

54.9k9 gold badges78 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Matt Greer Over a year ago

For sure. Time and dates are messy and inconsistent. Hand rolled solutions involving them almost always include bugs. Much better to go with a well tested library if possible.

Mike Rifgin Over a year ago

THis doesn't work. I just get and error saying (18).years().ago().isBefore is not a function...I do have the library included

Mike Rifgin Over a year ago

This library is in alpha testing. I've just done some simple calculations with it and it is not reliable

Marcel Jackwerth Over a year ago

My fault. isBefore was introduced after that alpha release. If using datejs it's best to use the latest version from https://github.com/datejs/Datejs.

Martin Hennings · Accepted Answer · 2011-03-29 13:37:24Z

1

That's because you forgot the leap years.

These years had 366 days and occur usually every four years, so in any 18 years there are about four days more than 365*18, thus moving the neccessary start date four days ahead.

Probably in this case it is easier to check

if ((nowyear - birthyear > 18) 
   || ((nowyear - birthyear == 18)&&(nowmonth - birthmonth > 0))
   || ((nowyear - birthyear == 18)&&(nowmonth == birthmonth)&&(nowday - birthday >= 0)))
  // you're 18!

edited Mar 29, 2011 at 13:37

answered Mar 29, 2011 at 13:32

Martin Hennings

17k9 gold badges51 silver badges70 bronze badges

2 Comments

Adriano Varoli Piazza Over a year ago

Your last condition only checks that the months are equal and the current day is greater than the birthday, but doesn't check the years.

Mike Rifgin Over a year ago

I don't know how to split the date up in to years and months. I have the birth year/month/day split up but how do i create todays date and get that in months/days/years?

Stefan Kendall · Accepted Answer · 2011-03-29 13:34:01Z

1

If you're looking for age, why not just go the simple route and deal with years, months, and days?

function findAge( birthday ){
   var today = new Date();
   var age = today.getFullYears() - birthday.getFullYears();
   if( today.getMonth() - birthday.getMonth() < 0 ){
      age--;
   }
   else if( today.getDay() - birthday.getDay() < 0 && today.getMonth() == birthday.getMonth() ){
      age--;
   }
}

answered Mar 29, 2011 at 13:34

Stefan Kendall

68.2k69 gold badges259 silver badges409 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:04:13Z

-1

try to take a look at this post

edited May 23, 2017 at 12:04

CommunityBot

11 silver badge

answered Mar 29, 2011 at 13:37

Faber

2,2042 gold badges28 silver badges37 bronze badges

1 Comment

Chris Shouts Over a year ago

That doesn't answer the OP's question.

Collectives™ on Stack Overflow

Problem with comparing dates in javascript

4 Answers 4

4 Comments

2 Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related