Sorting vs if else if in javascript which one to choose?

Question

I have a scenario in which I need to display the data in an increasing order of the index number.

myArray = [
{custom_carousel: false, default_label: "SmartCards", index: 3, visible: true}, 
{custom_carousel: false, default_label: "Pathways", index: 2, visible: false},
{custom_carousel: false, default_label: "Pathways", index: 1, visible: false},
{custom_carousel: false, default_label: "Pathways", index: 0, visible: false}
]

Should I first sort the array or add if else if condition ?

if(index === 0){

}else if (index === 1){

}else if (index === 2){

}else if (index === 3){

}

.sort obviously. What if you have more items in your array? Are you gonna go and change the code and add more ifs every time that happens? "2 or more times? Do a loop." — nicholaswmin
– nicholaswmin, Commented Jan 31, 2019 at 12:41
Just use myArray.sort((a,b) => a.index - b.index) and loop through them for whatever you need them for. — adiga
– adiga, Commented Jan 31, 2019 at 12:42
Possible duplicate of Sorting an array of JavaScript objects and Sort Array based on Object Attribute - Javascript — adiga
– adiga, Commented Jan 31, 2019 at 12:47
I've commented above but reading this again I'm a bit confused. How exactly would you use the if/else to sort? — nicholaswmin
– nicholaswmin, Commented Jan 31, 2019 at 12:49
@adiga this is not a duplicate question. I need to know which one should be preferred. — vikas95prasad
– vikas95prasad, Commented Jan 31, 2019 at 12:50

SLePort · Accepted Answer · 2019-01-31 12:43:49Z

2

You can use the sort method based on index values:

myArray = [
{custom_carousel: false, default_label: "Pathways", index: 2, visible: false},
{custom_carousel: false, default_label: "SmartCards", index: 3, visible: true}, 
{custom_carousel: false, default_label: "Pathways", index: 1, visible: false},
{custom_carousel: false, default_label: "Pathways", index: 0, visible: false}
]
console.log(myArray.sort((a,b)=>a.index - b.index));

answered Jan 31, 2019 at 12:43

SLePort

15.5k3 gold badges40 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Stiks · Accepted Answer · 2019-01-31 12:44:26Z

2

myArray.sort(function(a, b){return a.index - b.index});

Will sort your array by index

answered Jan 31, 2019 at 12:44

Stiks

2211 silver badge9 bronze badges

Comments

Alexey · Accepted Answer · 2019-01-31 12:43:41Z

1

Sorting will take O(n+log(n)) time and if-else-if-else will take O(n²) time. So sorting is better choice.

edited Jan 31, 2019 at 12:43

answered Jan 31, 2019 at 12:42

Alexey

717 bronze badges

2 Comments

nicholaswmin Over a year ago

I'm not -1 but why is complexity even a question here?

Alexey Over a year ago

Author asked which one they must choose. I give one of reasons.

Nina Scholz · Accepted Answer · 2019-01-31 12:55:49Z

I suggest to sort the array in advance and then access by the index of the array.

Reasons

easy to maintain with more elements of the array
easy to access in wanted order
code ie easy to understand, instead of having some code, which reason is not obvious and requieres explanation
access is fast, instead of iterating the array always from the beginning for getting the next item.

var myArray = [{ custom_carousel: false, default_label: "SmartCards", index: 3, visible: true }, { custom_carousel: false, default_label: "Pathways", index: 2, visible: false }, { custom_carousel: false, default_label: "Pathways", index: 1, visible: false }, { custom_carousel: false, default_label: "Pathways", index: 0, visible: false }]

myArray.sort(({ index: a }, { index: b }) => a - b);

console.log(myArray);

Collectives™ on Stack Overflow

Sorting vs if else if in javascript which one to choose?

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related