Changing to custom domain on Github Pages causes create-react-app with react-router to stop working

Question

So my app, /portfolio, works fine when deployed to the normal github hosting. You can see that here. But when I switch to a custom domain the app doesn't want to mount. I did a bit of research and assumed it has to do with react-router but I can't seem to figure it out.

Heres my BrowserRouter code:

<BrowserRouter basename={process.env.PUBLIC_URL}>
  <App />
</BrowserRouter>,

Which leaders to /portolio/ as the basename. I assume it should correctly change when on the custom domain but I played with it to no effect.

Any hints on what could be going wrong?

geeberry · Accepted Answer · 2019-01-07 01:41:43Z

1

Turns out create-react-app docs actually highlight this problem. Github pages doesn't play well with BrowserRouter. Theres a sort of hack in the documents here that worked swimmingly for me.

answered Jan 7, 2019 at 1:41

geeberry

6853 gold badges10 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Changing to custom domain on Github Pages causes create-react-app with react-router to stop working

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related