Calling a JavaScript function outside of the js file

Question

I have problems with calling a JavaScript function (which is inside of an object, in it's own .js file) from an other HTML page. In the code exsample I'll just use a simple Hello World function.

    //.js file

    window.addEvent('domready',function(){

      var Site = {
        //Here I have like three other functions

        //This function I want to detect the browser version. I use MooTools for this
        detectBrowser : function(){
         if(Browser.ie){
          //Then what ever content goes here
         }
        } 
       }

       //I execute the other three functions here because they need to be called on every page
       Site.dropdownmenu();
       Site.accordion();
       Site.lightbox();
     });

I'm working with MooTools so I have wraped everything inside of the domready function.
Now, I want this cetect function to execute only at one page. I have tried somethink like this:

    //In the HTML file between two script tags:
    Site.alert();

That does'nt work. Any ideas?
If I execute it in the .js file it works fine. But I don't want it to execute at every page.

alert is a standard javascript function so call it something else for a start — cusimar9
– cusimar9, Commented Mar 6, 2011 at 14:02
You have not posted enough of the code involved for anybody to know what's wrong. — Pointy
– Pointy, Commented Mar 6, 2011 at 14:04
@Emil I repeat, you have not posted enough code. Show us what is surrounding that definition of "Site". Is it inside another function, for example? — Pointy
– Pointy, Commented Mar 6, 2011 at 14:22

outis · Accepted Answer · 2011-03-06 14:44:11Z

1

If you declare a variable with var in a function, the variable is local to that function and inaccessible from outside that function. To make it explicitly global, declare it as a property of window:

window.addEvent('domready',function(){
    window.Site = ...

This isn't necessary for the code to work, it just makes it explicit for programmers that might read your code that Site is a global.

answered Mar 6, 2011 at 14:44

outis

77.7k23 gold badges155 silver badges228 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Emil Over a year ago

Yes, but I think that, that is the problem. The Site variable is not global. You can only access it inside the Site object.

outis Over a year ago

Which is why you shouldn't use var if you wish to access it outside the function. Not also that globals are generally bad, though it may be justified in this case.

Emil Over a year ago

I tried to remove the var and replace it with window.Site = {... It still does'nt work. I don't know what's going on

SLaks · Accepted Answer · 2011-03-06 14:01:49Z

1

External Javascript files just execute code; the code doesn't know where it's coming from.

As long as your code runs after the external JS file, it will work fine.

answered Mar 6, 2011 at 14:01

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Collectives™ on Stack Overflow

Calling a JavaScript function outside of the js file

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related