Issues with counters in while loop Python

Question

I'm currently having an issue in my code, in which I am attempting to create a rock paper scissors game. My counting method does not seem to work (when the program looped the win loss counters are both on 0), so I was hoping I could get some help. I am fairly new to Python and stack overflow, so bear that in mind. Sorry for the long wall of code:

import random
import time
win=0
loss=0
def compare():
  if choice == "rock" and opp == "paper":
    print("You lose!")
    loss+1
  elif choice == "paper" and opp == "scissors":
    print("You lose!")
    loss+1
  elif choice== "scissors" and opp == "rock":
    print("you lose")
    loss+1
  elif choice == "scissors" and opp == "paper":
    print("you win")
    win+1
  elif choice == "rock" and opp =="scissors":
    print("you win")
    win+1
  elif choice == "paper" and opp == "rock":
    print("you win!")
    win+1
  else:
    print("...")
op=["rock","paper","scissors"]
phrase=["Rock paper scissors shoot!","janken bo!", "pierre-feuille-ciseaux!","papier, kamień, nożyczki!"]

while True:
  print ("You have",win,"wins and",loss,"losses")
  choice=input(random.choice(phrase)).lower()
  if choice not in op:
    print("Rock paper or scissors")
    continue
  else:
    print()
  opp=random.choice(op)
  print (opp)
  compare()
  while opp==choice:
    choice=input(random.choice(phrase)).lower()
    time.sleep(1)
    opp=random.choice(op)
    print (opp)
    compare()

I appreciate any help. Thanks

You are not assigning win + 1 - I suspect you mean win = win + 1, or win += 1 in short. — Nelewout
– Nelewout, Commented Jul 12, 2018 at 13:58
You also need to declare global win and global loss inside compare if you're going to assign to them inside the function. — khelwood
– khelwood, Commented Jul 12, 2018 at 14:10

madjaoue · Accepted Answer · 2018-07-13 12:00:27Z

2

Each time you write variable + 1, you don't alter the variable. For example in :

def compare():
  if choice == "rock" and opp == "paper":
    print("You lose!")
    loss+1

loss+1 does nothing, i.e the value is not assigned.

You need to assign the value to your variable. For example : loss += 1

edited Jul 13, 2018 at 12:00

answered Jul 12, 2018 at 13:58

madjaoue

5,2142 gold badges21 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ltd9938 · Accepted Answer · 2018-07-12 13:59:26Z

1

Welcome to StackOverflow!

In your if statements you aren't actually incrementing the counts. You need to do win = win + 1 and loss = loss + 1

def compare():
  if choice == "rock" and opp == "paper":
    print("You lose!")
    loss = loss + 1

Now you can also do some "shorthand" syntax. loss += 1 is equivalent to loss = loss + 1.

answered Jul 12, 2018 at 13:59

ltd9938

1,4541 gold badge17 silver badges29 bronze badges

Collectives™ on Stack Overflow

Issues with counters in while loop Python

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related