Variable not defined - Scope Issue ? - JavaScript

Question

in the console its giving me the error 'position not defined' using the the code below.. any ideas?

var x = 1;
var y = 1;

function getyx(y, x) {
	var yx = 'Y' + y + 'X' + x ;
	return yx;
}

function getPosition() {
  var position = document.getElementById(getyx(y,x));
	return position;
}

function moveSprite() {
	position.appendChild(img); //error occurs here
}

Maybe get element by Id cant accept a function ? I know this may be a silly question but forgive me :)

I think what you need is GetPosition().appendChild(img);

Dragonthoughts
– Dragonthoughts

2018-06-09 20:58:08 +00:00
Commented Jun 9, 2018 at 20:58 — Dragonthoughts
– Dragonthoughts, Commented Jun 9, 2018 at 20:58
img is not defined anywhere in your provided code.

Get Off My Lawn
– Get Off My Lawn

2018-06-09 20:58:10 +00:00
Commented Jun 9, 2018 at 20:58 — Get Off My Lawn
– Get Off My Lawn, Commented Jun 9, 2018 at 20:58

CertainPerformance · Accepted Answer · 2018-06-09 20:56:14Z

1

It looks like getPosition is the function that selects the element you want, so try calling that function:

function moveSprite() {
  const position = getPosition();
  position.appendChild(img);
}

There's absolutely nothing wrong with passing a string created by a function to getElementById

answered Jun 9, 2018 at 20:56

CertainPerformance

373k55 gold badges354 silver badges359 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Rob Anderson Over a year ago

I've been stuck on this problem for about 3 hours now. You my friend are the man (or woman) ! Thank again

AkiraMiura · Accepted Answer · 2018-06-09 21:05:26Z

0

The reason it is saying position can be a few problems, the simplest being you don't have "Y1X1" as an HTML ID.

Seen as your function returns a string it would be able to use getElementById(). If your not sure about the scope, you can go to the top of your code and use var position; however it's most likely not a scope issue.

answered Jun 9, 2018 at 21:05

AkiraMiura

842 silver badges6 bronze badges

Collectives™ on Stack Overflow

Variable not defined - Scope Issue ? - JavaScript

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related