setting value in array list from Map

Question

Am fetching records from elasticsearch and am trying to return as a list. But am getting error while adding to the list from sourceAsMap

Please find my code below.

SearchHit[] searchHits = searchResponse.getHits().getHits();
    List<Product> productList=new ArrayList<Product>();
    for (SearchHit hit : searchHits) {
        // get each hit as a Map

        Map<String, Object> sourceAsMap = hit.getSourceAsMap();
        product=new Product();
        product.setName(sourceAsMap.get("name").toString());
        productList.add(product.setName(sourceAsMap.get("name").toString()));  // throwing error in this line

    }

    return productList;
}

Please find my POJO class:

@JsonInclude(JsonInclude.Include.NON_EMPTY)
public class Product {

    private String id;
    private String name;

    public String getId() {
        return id;
    }
    public void setId(String id) {
        this.id = id;
    }
    public String getName() {
        return name;
    }
    public void setName(String name) {
        this.name = name;
    }

}

Do you have a stack trace?

KeyMaker00
– KeyMaker00

2018-05-24 18:13:28 +00:00
Commented May 24, 2018 at 18:13 — KeyMaker00
– KeyMaker00, Commented May 24, 2018 at 18:13

Amit Bera · Accepted Answer · 2018-05-24 18:16:58Z

1

I believe you are getting The method add(void) is undefined for the type Product.Your Product#setName methods return type is void, so you are actually trying to add void to List of Product. You should do productList.add(product) instead of productList.add(product.setName(sourceAsMap.get("name").toString()));

Your code should looks like below:

    Map<String, Object> sourceAsMap = hit.getSourceAsMap();
    product=new Product();
    product.setName(sourceAsMap.get("name").toString());
    productList.add(product);

edited May 24, 2018 at 18:16

answered May 24, 2018 at 18:10

Amit Bera

7,2551 gold badge22 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Karthikeyan Over a year ago

I have added my POJO class too. to which method i have to change the return type as void to List..?

Amit Bera Over a year ago

@Karthikeyan You don't need to change anything only use productList.add(product) instead of productList.add(product.setName(sourceAsMap.get("name").toString())); wil solve your problem

Collectives™ on Stack Overflow

setting value in array list from Map

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related