Bash if else statement syntax error

Question

So I have this little problem. I'm not sure where it went wrong because I'm pretty sure I got the code right. Here's the code:

#!/bin/bash
playerHP=100
echo "Hello World"
echo "HP: $playerHP"
echo "Continue? (Y/N):"
read -p $confirm
if [ "$confirm" = "y" ]
then
    echo "Yes"
elif [ "$confirm" = "n" ]
then
    echo "No"
else
    echo "No such command"
fi

Here's the result:

The code you post in your question is different from the code in the error message. Hint: missing quotes. — glenn jackman
– glenn jackman, Commented Apr 5, 2018 at 14:56
The code you posted does not conform to the code you are running. You posted [ "$confirm" = "n" ] (good!), but the error message implies [ $confirm == "n" ] (bad). — chepner
– chepner, Commented Apr 5, 2018 at 14:58

choroba · Accepted Answer · 2018-04-05 14:55:25Z

5

Unrelated: read needs a prompt after -p. Blend the previous echo into it, and while at it, remove the $ from the variable name there.

read -p "Continue? (Y/N):" confirm

The error message is confusing. Don't you have MSWin line ends in the script?

answered Apr 5, 2018 at 14:55

choroba

245k27 gold badges221 silver badges304 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Aaron Over a year ago

It's more than "while at it" : with the $ the $confirm variable is expanded to the empty string before the read builtin is run and the user input is lost.

Gordon Davisson Over a year ago

The rule is that $variablename is used to get the value of the variable; when setting a variable (in an assignment, with read, whatever) just use the plain variable name without the $.

Abhijit Pritam Dutta · Accepted Answer · 2018-04-05 15:10:04Z

1

Hi I have modified your script below use it. Working fine for me

#!/bin/bash
playerHP=100
echo "Hello World"
echo "HP: $playerHP"
read -p "Continue? (Y/N): " confirm
echo $confirm

if [ "$confirm" = "y" ]
then
    echo "Yes"
elif [ "$confirm" = "n" ]
then
    echo "No"
else
    echo "No such command"
fi

answered Apr 5, 2018 at 15:10

Abhijit Pritam Dutta

5,6112 gold badges13 silver badges17 bronze badges

4 Comments

EneioArzew Over a year ago

These are the errors I get: ': not a valid identifier: confirm gametest.sh: line 7: $'\r': command not found gametest.sh: line 11: syntax error near unexpected token elif' 'ametest.sh: line 11: `elif [ "$confirm" = "n" ]

Abhijit Pritam Dutta Over a year ago

can you just execute this line in your command prompt and let me know if [ "y" = "y" ]; then echo "correct"; fi and if [ "y" == "y" ]; then echo "correct"; fi.

kyodev Over a year ago

gametest.sh: line 7: $'\r'... RC windows?

Abhijit Pritam Dutta Over a year ago

change this line #!/bin/bash to #!/bin/ksh

Collectives™ on Stack Overflow

Bash if else statement syntax error

2 Answers 2

2 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related