Populate array in for loop (JS)

Question

I have js code

var model = {
    start: newstart,
    end: newstop,
    imei: imei
};
$.ajax({
    url: dburl,
    dataType: 'json',
    type: 'GET',
    data: model,
    success: function (data) {
         speeddata = data;

         if (speeddata.length !== 0) {
             for (var i = 0; i < speeddata.length; i++) {
                 path = "path=" + speeddata[i].Latitude2 + ',' + speeddata[i].Longitude2;
                 var googleurl = "https://roads.googleapis.com/v1/speedLimits?"
                     + path + "&key=" + roadsapikey;
                 + path + "&key=" + roadsapikey;
                 $.ajax({
                     url: googleurl,
                     dataType: 'json',
                     type: 'GET',
                     success: function (data) {

                         for (var i = 0; i < data.speedLimits.length; i++) {
                             speedobject.push({
                                 speedlimits: data.speedLimits[i].speedLimit
                             });
                         }
                         console.log(speedobject);
                     }

                 });
             }

         }
    },
    error: function () {
        alert("Error");
    }
});

In this code I get data from db and write it to speeddata array, I have 6 elements in array.

   var speeddata = [{
Imei: 35745407257535, Latitude2: 50.9364, Longitude2: 3.12147, Speed: 8
},{
Imei: 35745407257535, Latitude2: 50.93918, Longitude2: 3.12485, Speed: 37
},{
Imei: 35745407257535, Latitude2: 50.93997, Longitude2: 3.12837, Speed: 7
},{
Imei: 35745407257535, Latitude2: 50.93834, Longitude2: 3.12893, Speed: 54
},{
Imei: 35745407257535, Latitude2: 50.9281, Longitude2: 3.13903, Speed: 56
},{
Imei: 35745407257535, Latitude2: 50.9219, Longitude2: 3.15888, Speed: 9
}];

After this I need to get speedlimit for every element in speeddata and write it to speedobject.

I try to it like here

 if (speeddata.length !== 0) {
             for (var i = 0; i < speeddata.length; i++) {
                 path = "path=" + speeddata[i].Latitude2 + ',' + speeddata[i].Longitude2;
                 var googleurl = "https://roads.googleapis.com/v1/speedLimits?"
                     + path + "&key=" + roadsapikey;
                 + path + "&key=" + roadsapikey;
                 $.ajax({
                     url: googleurl,
                     dataType: 'json',
                     type: 'GET',
                     success: function (data) {

                         for (var i = 0; i < data.speedLimits.length; i++) {
                             speedobject.push({
                                 speedlimits: data.speedLimits[i].speedLimit
                             });
                         }
                         console.log(speedobject);
                     }

                 });
             }

         }

But I have 6 repeats when console.log speedobject.

Here is array

Screen of google api array

So if I want to display it in table I will have 36 entries instead of 6

Where is my trouble?

Thank's for help.

Can you give a fiddle link and data object w/o the AJAX call? — Pavan
– Pavan, Commented Jan 22, 2018 at 14:32
I cannot create fiddle, because it will have google roads api key. But I included speeddata data@Pavan — Yevhen
– Yevhen, Commented Jan 22, 2018 at 14:43
After this I need to get speedlimit for every element in speeddata and write it to speedobject. I writed in post all info about me trouble @Pavan — Yevhen
– Yevhen, Commented Jan 22, 2018 at 14:48

Mikhail Katrin · Accepted Answer · 2018-01-23 09:29:23Z

1

As I understood it, you want to have 6 entries each with an array of speedlimits, like this:

success: function (data) {
    var speedLimits = []
    for (var i = 0; i< data.speedLimits.length;i++) {
        speedLimits.push(data.speedLimits[i].speedLimit);
    }
    speedobject.push({speedLimits: speedLimits})
    console.log(speedobject);
}

edited Jan 23, 2018 at 9:29

Mikhail Katrin

2,4041 gold badge12 silver badges17 bronze badges

answered Jan 22, 2018 at 15:17

Bamse

4935 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Yevhen Over a year ago

Nope. I need need to get speedLimit property for every element in speeddata. I updated post, check it.

Viplock · Accepted Answer · 2018-01-23 09:49:12Z

0

Update your code like

 if (speeddata.length !== 0) {
             for (var i = 0; i < speeddata.length; i++) {
                 path = "path=" + speeddata[i].Latitude2 + ',' + speeddata[i].Longitude2;
                 var googleurl = "https://roads.googleapis.com/v1/speedLimits?"
                     + path + "&key=" + roadsapikey;
                 + path + "&key=" + roadsapikey;
                 $.ajax({
                     url: googleurl,
                     dataType: 'json',
                     async: false, 
                     type: 'GET',
                     success: function (data) {

                             speeddata[i].speedlimits=data.speedLimits;

                     }

                 });
             }

         }

Updated the success function.

add comment if some problem

Edit: I have added async: false, to the call by that you will be able to fill speeddata object in it. Oter way is to make a callback by refactoring the code

edited Jan 23, 2018 at 9:49

answered Jan 22, 2018 at 15:11

Viplock

3,3191 gold badge26 silver badges34 bronze badges

8 Comments

Yevhen Over a year ago

Cannot set property 'speedlimits' of undefined

Yevhen Over a year ago

I will now post screen of response from google and update post

Viplock Over a year ago

how this data object is like success: function (data) {... what is in data you are geeting from ajex call?

Yevhen Over a year ago

I paste screen shot in post.

Viplock Over a year ago

can you access speeddata inside success?

|

Collectives™ on Stack Overflow

Populate array in for loop (JS)

2 Answers 2

1 Comment

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related